-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] datalog (0.7) #26751
[new release] datalog (0.7) #26751
Conversation
d133d77
to
ce3bad3
Compare
CHANGES: - compat with OCaml 5.2 - fix location reporting in parse errors
ce3bad3
to
f3ed2ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for publishing the package update :)
I see several CI failures that look to be failing tests on some platforms. Could you take a look at those when you have a chance?
We also have this dune subst thing. If you don't mind, I can just commit the fix in directly.
Co-authored-by: Shon Feder <shon.feder@gmail.com>
seems good to me, honestly. It seems that on x32 the tests sometimes fail because the hashtbl traversal order is different, which is not a big deal. |
Since hey are not signs of problems, makes sense not to block on this. But fixing the tests so that they are reliable across different platforms will prevent having to face this kind of snag in the future. Would accept a PR to make the tests more robust across platforms? Thanks very much for publishing the update, and of course for the nice library and utility :) |
Sure, yeah, in this case it's 10 yo tests that I didn't bother making deterministic (by sorting) :) |
An in-memory datalog implementation for OCaml
CHANGES: