Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] datalog (0.7) #26751

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

c-cube
Copy link
Contributor

@c-cube c-cube commented Oct 16, 2024

An in-memory datalog implementation for OCaml

CHANGES:
  • compat with OCaml 5.2
  • fix location reporting in parse errors

CHANGES:

- compat with OCaml 5.2
- fix location reporting in parse errors
Copy link
Collaborator

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for publishing the package update :)

I see several CI failures that look to be failing tests on some platforms. Could you take a look at those when you have a chance?

We also have this dune subst thing. If you don't mind, I can just commit the fix in directly.

packages/datalog/datalog.0.7/opam Outdated Show resolved Hide resolved
Co-authored-by: Shon Feder <shon.feder@gmail.com>
@c-cube
Copy link
Contributor Author

c-cube commented Oct 17, 2024

seems good to me, honestly. It seems that on x32 the tests sometimes fail because the hashtbl traversal order is different, which is not a big deal.

@shonfeder
Copy link
Collaborator

seems good to me, honestly. It seems that on x32 the tests sometimes fail because the hashtbl traversal order is different, which is not a big deal.

Since hey are not signs of problems, makes sense not to block on this. But fixing the tests so that they are reliable across different platforms will prevent having to face this kind of snag in the future. Would accept a PR to make the tests more robust across platforms?


Thanks very much for publishing the update, and of course for the nice library and utility :)

@shonfeder shonfeder merged commit 6c34aa1 into ocaml:master Oct 18, 2024
2 of 3 checks passed
@c-cube
Copy link
Contributor Author

c-cube commented Oct 18, 2024

Sure, yeah, in this case it's 10 yo tests that I didn't bother making deterministic (by sorting) :)

@c-cube c-cube deleted the release-datalog-v0.7 branch October 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants