hol_light: fix wrong paths in hol.sh, copy src to lib #26760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes hidden bugs in hol_light's opam which did not reveal when installing hol_light locally, but appear when installed from remote git. Also, this patch copies the source files in the build directory to hol_light:lib because all .ml files can actually matter when hol.sh is used in HOL Light. My previous patch was my first contribution to OPAM, so these points were missed. :/ Since I didn't publicly announce the new HOL Light package, and this is a bug fix in its OPAM configuration, I believe (hope) incrementing its version to 3.0.1 is not necessary.
|
The one remaining failure in CI is a reproduction of this: #26745 (comment) .. which is orthogonal to this change. This patch is ready to get reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes hidden bugs in hol_light's opam which did not reveal when installing hol_light locally, but appear when installed from remote git.
Also, this patch copies the source files in the build directory to hol_light:lib because all .ml files can actually matter when hol.sh is used in HOL Light. My previous patch was my first contribution to OPAM, so these points were missed. :/ Since I didn't publicly announce the new HOL Light package, and this is a bug fix in its OPAM configuration, I believe (hope) incrementing its version to 3.0.1 is not necessary.