Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee full execution of ban #39

Open
TimDaub opened this issue Mar 16, 2021 · 2 comments
Open

Guarantee full execution of ban #39

TimDaub opened this issue Mar 16, 2021 · 2 comments
Labels

Comments

@TimDaub
Copy link
Contributor

TimDaub commented Mar 16, 2021

In #23, an account owner was banned but not their data sets. This issue was addressed months later in #37. I've not been part of the situation that lead to the account owner's ban, but I was naturally assuming that when an owner's account is banned, so are all their data sets.

I'm aware that there may be exceptions to this specific case, but using this repository's data, I'd be confident knowing that an account ban always includes a data set ban too. I'm arguing for this, as rugpullindex.com showed the banned owner's data sets for a few days without anyone realizing that they belong to a banned account. Rugpullindex.com has always filtered for both DIDs and accounts from this repository.

I think that a GitHub Action that runs the proposed account through the marketplace data to verify all data sets of an account have been banned would be an appropriate and automated solution we can all rely upon. Please let me know if that's of interest and I can think of sending a PR.

@trentmc
Copy link
Member

trentmc commented Mar 16, 2021

I was naturally assuming that when an owner's account is banned, so are all their data sets.

Yes, this should be the case, according to the rules laid out in this repo's README.

I think that a GitHub Action that runs the proposed account through the marketplace data to verify all data sets of an account have been banned would be an appropriate and automated solution we can all rely upon.

I like this idea.

Thoughts @kremalicious @brucepon ?

@trentmc trentmc added the Type: Enhancement New feature or request label Mar 20, 2021
@TimDaub
Copy link
Contributor Author

TimDaub commented Mar 22, 2021

Getting a list of assets for an owner:

And the other way around, getting the owner for an asset should be straight-forward given that their address likely in the DDO somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants