Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite sorry/unsorry in python #121

Open
jvperrin opened this issue Jul 13, 2019 · 2 comments
Open

Rewrite sorry/unsorry in python #121

jvperrin opened this issue Jul 13, 2019 · 2 comments

Comments

@jvperrin
Copy link
Member

Currently sorry and unsorry are pretty complicated scripts to be written in bash and have commented out sections, shellcheck-ignored warnings, etc. It's also tough to know if things done in the sorry script are undone properly in the unsorry script (setting file permissions for instance), so rewriting these two to use common functions and better error handling (maybe even be in the same script file) would be useful.

@fawaf
Copy link
Member

fawaf commented Jul 15, 2019

oh wow, unsorry/sorry is still that terrible bash script? nice.

@jvperrin
Copy link
Member Author

Yup, exactly, every time I have to look at it or use it and it breaks halfway through I get sad :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants