config save breaks if files with spaces in name are in /etc

[renatoram]

Problem: if a file with a space in the name is present in /etc, saving the configuration breaks.

A cursory look at /usr/local/sbin/config seems to point at the "find" cycles where the cycle variable $i is used unquoted (there's a couple of those).

Replacing all occurrences of $i with ${i} should be sufficient, I suppose.

[ocochard]

Should be fixed with 1f818eb

root@router:~ # touch /etc/"yo yo.txt"
root@router:~ # wr
Archiving previous configuration files...
Saving configuration...
Done.

[ocochard]

But how did you end up with spaces in your filename anyway ? :-)

[renatoram]

Well, in this case it was accidental 😄 , but it's a legitimate thing... and (most importantly) using unquoted variables could easily lead to really nasty unexpected bugs (some of the commands in the script could have used the second part of the filename as additional parameter, and such).