New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses deprecated Longident.parse #266

Open

rwmjones opened this issue Apr 22, 2020 · 1 comment

rwmjones commented Apr 22, 2020

With OCaml 4.11 you get this deprecation warning when compiling tyxml. I believe this is causing a fatal build error.

46 |     (Longident.parse @@ implementation i ^ "." ^ s)
          ^^^^^^^^^^^^^^^
Error (alert deprecated): Migrate_parsetree.Ast_405.Longident.parse
this function may misparse its input,
use "Parse.longident" or "Longident.unflatten"

Full build log is here:
https://kojipkgs.fedoraproject.org//work/tasks/3434/43633434/build.log

The text was updated successfully, but these errors were encountered:

Author

rwmjones commented Apr 22, 2020

By the way, for anyone who wants to just make it compile an easy workaround is:

--- tyxml-4.3.0.old/ppx/dune	2018-11-18 16:33:55.000000000 +0000
+++ tyxml-4.3.0.new/ppx/dune	2020-04-22 12:31:39.835610341 +0100
@@ -30,6 +30,6 @@
          -open Migrate_parsetree
          -open Ast_405
          -open Ppx_tools_405
-         -w "-9"
+         -w "-3-9"
  ))
 )

Obviously this is not a correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment