Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show invalid words on word completion instead of enter #136

Open
RobinSmithCA opened this issue Apr 12, 2022 · 1 comment
Open

Show invalid words on word completion instead of enter #136

RobinSmithCA opened this issue Apr 12, 2022 · 1 comment

Comments

@RobinSmithCA
Copy link

When the entered word is invalid, I must use an extra keystroke to hit 'enter' only to have the circles come up red. Could the validity test not be done on entry of my final letter?

@LWChris
Copy link
Contributor

LWChris commented Sep 25, 2022

Currently the validity check is inside the routine of the solution check that is triggered when you press "Enter".

Basically, when you press enter, the solution check runs through several stages of checks, returning with the most appropriate error message when a check fails. "Not a valid word" is just one of them, along with "Less than 5 letters have been entered" etc.

Since Easy mode does not require a valid word, it's easy to implement it this way where you just skip this particular check for that mode. However, I'm confident the code could probably be changed to a multi-level solution check, one that is run on each letter (conflicting hints), one that is run when you hit 5 letters (valid word), and one on "Enter", which behaved like it does now, i. e. explicitly checks for everything and is also the only one that can possibly "lock in" an answer and count towards the attempts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants