ensure ogip lightcurve is produced by oda api

[volodymyrss]

as reminded by esg-epfl-apc/tools-astro#115 (comment) and it's good to follow the standard.

@burnout87 I think you dealt with this?

[burnout87]

I suppose you refer to

oda_api/oda_api/plot_tools.py

Line 418 in 7dcb229

class OdaLightCurve(OdaProduct):

?

@ferrigno and I worked on it (mainly) for the gallery

[dsavchenko]

I suppose you refer to

It's about

oda_api/oda_api/data_products.py

Line 754 in 7dcb229

class LightCurveDataProduct(NumpyDataProduct):

Of course, these parts should not be completely separated (as well as image, spectrum etc)
This will require some refactoring

Even worse, we have some logic (mainly visualisation) in dispatcher plugin https://github.com/oda-hub/dispatcher-plugin-nb2workflow/blob/9ea4d3c8202ca500e3cc0bf9f7a2ffb9d4755d4f/dispatcher_plugin_nb2workflow/products.py#L241 which refers to the main code https://github.com/oda-hub/dispatcher-app/blob/e8f8082f68008510a7c9e865ff883c34852890a4/cdci_data_analysis/analysis/products.py#L406 completely separate from what's in oda_api. Not saying that we will also have a js visualisation library...

[volodymyrss]

need to replace this with the coming ogip functionality

when reading from file, there should be product-specific validation and transformation (i.e. loose reading and strict writing)