Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] - Would it be ok to move to using Vite ? #17

Open
VicGUTT opened this issue Aug 5, 2022 · 9 comments
Open

[Question] - Would it be ok to move to using Vite ? #17

VicGUTT opened this issue Aug 5, 2022 · 9 comments
Labels
discussion question Further information is requested

Comments

@VicGUTT
Copy link
Contributor

VicGUTT commented Aug 5, 2022

I'm wondering if it'd be ok to move to using ViteJS (which makes use of ESBuild under the hood) instead of raw ESBuild?

(Very biased/Personal) Benefits:

  • Nice "wrapper" around ESBuild providing a better DX (Developer Experience)
  • Ability to use Vitest
  • "build:esm:module": "esbuild src/*.ts src/*.css --outdir=dist/ --format=esm" and other scripts won't break on my machine anymore 😅 (on Windows 👀 )
@oluoluoxenfree oluoluoxenfree added question Further information is requested discussion labels Aug 5, 2022
@oluoluoxenfree
Copy link
Contributor

Any thoughts @sana @jerivas @jgerigmeyer?

@jgerigmeyer
Copy link
Member

@VicGUTT I approve! I actually have been working on converting https://github.com/oddbird/css-anchor-positioning to use Vite (as well as some other dev-tooling changes), and then I was planning to backport those to https://github.com/oddbird/polyfill-template next week.

@jgerigmeyer
Copy link
Member

@VicGUTT
Copy link
Contributor Author

VicGUTT commented Aug 6, 2022

Nice :)
Shall I wait or can I get the work started? It see the linked PR is missing one reviewer approval for now so I'm guessing it might be best to wait

@jgerigmeyer
Copy link
Member

jgerigmeyer commented Aug 7, 2022

@VicGUTT It's up to you -- if you want to get started implementing something similar in this repo, I'd say go ahead 👍

But if you'd prefer to wait, or for me or someone else to make the changes here, that's fine too -- I should be able to look at this more this coming week.

@VicGUTT
Copy link
Contributor Author

VicGUTT commented Aug 10, 2022

Great ✌️. I'll get a crack at it later today :)

@jgerigmeyer
Copy link
Member

Great ✌️. I'll get a crack at it later today :)

@VicGUTT See oddbird/css-anchor-positioning#10 for a sample Vite/TypeScript build process. I'm planning to backport that general approach to https://github.com/oddbird/polyfill-template this week.

@VicGUTT
Copy link
Contributor Author

VicGUTT commented Aug 10, 2022

Alright, looking at now, thanks

@VicGUTT
Copy link
Contributor Author

VicGUTT commented Aug 11, 2022

Before going further here, I believe it to be best for me to contribute to the other repos and wait for the general tooling backports to the downstream repos :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants