Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] - support unsupported invokers #72

Open
yinonov opened this issue Feb 2, 2023 · 0 comments
Open

[Question] - support unsupported invokers #72

yinonov opened this issue Feb 2, 2023 · 0 comments

Comments

@yinonov
Copy link
Contributor

yinonov commented Feb 2, 2023

Common practice for custom-elements present a problem where host would fail to be recognized as supported invoker but its template should be.

<div popover id="mypopover"></div>

<my-button popovertoggletarget="mypopover">
  #shadow-root
  <button>

the above will not trigger the popover to show / hide.

follow that, common better practice will be to delegate the attribute downwards to the focused button

<div popover id="mypopover"></div>

<my-button popovertoggletarget="mypopover">
  #shadow-root
  <button popovertoggletarget="mypopover">

but that won't return the popover element as it doesn't exist in the shadowed button root node (where it will be queried)

What about simply aria role="button". should that be supported?

<span role="button">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant