Force boolean type when checking PKCE setting

oidc-wp · Jul 11, 2022 · 8c2fcc8 · 8c2fcc8
1 parent 66e1083
commit 8c2fcc8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/includes/openid-connect-generic-client-wrapper.php b/includes/openid-connect-generic-client-wrapper.php
@@ -123,7 +123,7 @@ public static function register( OpenID_Connect_Generic_Client $client, OpenID_C
 		}
 
 		// Modify authentication-token request to include PKCE code verifier.
-		if ( $settings->enable_pkce ) {
+		if ( true === (bool) $settings->enable_pkce ) {
 			add_filter( 'openid-connect-generic-alter-request', array( $client_wrapper, 'alter_authentication_token_request' ), 15, 3 );
 		}
 
@@ -237,7 +237,7 @@ public function get_authentication_url( $atts = array() ) {
 			$url_format .= '&acr_values=%7$s';
 		}
 
-		if ( $this->settings->enable_pkce ) {
+		if ( true === (bool) $this->settings->enable_pkce ) {
 			$pkce_data = $this->pkce_code_generator();
 			if ( false !== $pkce_data ) {
 				$url_format .= '&code_challenge=%8$s&code_challenge_method=%9$s';