drivers: msm: ipa_v2: reduce warning in dmesg

okta-10 · okta-10 · commit 218f8d5191d3 · 2022-03-20T19:05:07.000+07:00
[ 84.300583] ipa __ipa_generate_rt_hw_rule_v2:65 Wrong destination pipe specified in RT rule [ 84.300664] ------------[ cut here ]------------ [ 84.300669] WARNING: at ../drivers/platform/msm/ipa/ipa_v2/ipa_rt.c:66 [ 84.300673] [ 84.300684] CPU: 3 PID: 1338 Comm: ipacm Tainted: G W 4.4.205-Mystic-CAF_LA.UM.9.2.r1-03700-SDMxx0.0_beta-x9.3 #1 [ 84.300689] Hardware name: Qualcomm Technologies, Inc. SDM 636 PM660 + PM660L WHYRED QTI (DT) [ 84.300695] task: ffffffd2922dc240 task.stack: ffffffd219420000 [ 84.300709] PC is at __ipa_generate_rt_hw_rule_v2+0x14c/0x2c4 [ 84.300715] LR is at __ipa_generate_rt_hw_rule_v2+0x14c/0x2c4 [ 84.300720] pc : [<ffffff9f38173c0c>] lr : [<ffffff9f38173c0c>] pstate: 60400145 [ 84.300724] sp : ffffffd2194237f0 [ 84.300728] x29: ffffffd219423910 x28: 0000000000000001 [ 84.300735] x27: 0000000000000388 x26: ffffffd2b8614a18 [ 84.300741] x25: 0000000000000000 x24: ffffffd2b85f3610 [ 84.300747] x23: ffffffd2b8614a00 x22: ffffff9f39960000 [ 84.300753] x21: 0000000000000001 x20: ffffffd219423808 [ 84.300758] x19: ffffffd260a82000 x18: 00000000000b8c90 [ 84.300764] x17: ffffffd2ba070008 x16: ffffff9f396b0000 [ 84.300770] x15: 0000000000000070 x14: 6963657073206570 [ 84.300776] x13: 6970206e6f697461 x12: 6e69747365642067 [ 84.300782] x11: 0000000000000000 x10: 0000000000000000 [ 84.300787] x9 : 00000000000404cd x8 : 00000000000404cd [ 84.300793] x7 : ffffff9f39453d08 x6 : 000000000000005f [ 84.300799] x5 : 0000000000000000 x4 : ffffff9f396b3009 [ 84.300805] x3 : 0000000000000000 x2 : 0000000000000000 [ 84.300810] x1 : 0000000000000140 x0 : 000000000000004f [ 84.300817] \x0aPC: 0xffffff9f38173bcc: [ 84.300822] 3bcc f9003e9f a9057fff a9047fff a9037fff a9027fff a9017ff4 b9401660 9400339f [ 84.300840] 3bec 3100041f 54fff8c1 90005e40 90005e41 912c7000 912d5421 52800822 97ce726e [ 84.300856] 3c0c d4210000 14000036 90005e54 90005e40 912d5694 912dc800 aa1403e1 528008c2 [ 84.300871] 3c2c 97ce7265 90005e40 b9401664 912e9c00 aa1403e1 52800902 2a1603e3 97ce725e [ 84.300888] \x0aLR: 0xffffff9f38173bcc: [ 84.300893] 3bcc f9003e9f a9057fff a9047fff a9037fff a9027fff a9017ff4 b9401660 9400339f [ 84.300908] 3bec 3100041f 54fff8c1 90005e40 90005e41 912c7000 912d5421 52800822 97ce726e [ 84.300924] 3c0c d4210000 14000036 90005e54 90005e40 912d5694 912dc800 aa1403e1 528008c2 [ 84.300939] 3c2c 97ce7265 90005e40 b9401664 912e9c00 aa1403e1 52800902 2a1603e3 97ce725e [ 84.300956] \x0aSP: 0xffffffd2194237b0: [ 84.300961] 37b0 38173c0c ffffff9f 194237f0 ffffffd2 38173c0c ffffff9f 60400145 00000000 [ 84.300976] 37d0 19423910 ffffffd2 38173c0c ffffff9f 00000000 00000080 00000000 00000000 [ 84.300992] 37f0 00000001 00000000 08000000 ffff0000 19423808 ffffffd2 00000000 00000000 [ 84.301007] 3810 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 84.301022] [ 84.301027] ---[ end trace 0723b3f8a99998b6 ]--- Signed-off-by: Oktapra Amtono <oktapra.amtono@gmail.com>
diff --git a/drivers/platform/msm/ipa/ipa_v2/ipa_rt.c b/drivers/platform/msm/ipa/ipa_v2/ipa_rt.c
@@ -63,7 +63,7 @@ int __ipa_generate_rt_hw_rule_v2(enum ipa_ip_type ip,
 	pipe_idx = ipa2_get_ep_mapping(entry->rule.dst);
 	if (pipe_idx == -1) {
 		IPAERR("Wrong destination pipe specified in RT rule\n");
-		WARN_ON(1);
+		WARN_ON_ONCE(1);
 		return -EPERM;
 	}
 	if (!IPA_CLIENT_IS_CONS(entry->rule.dst)) {

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ int __ipa_generate_rt_hw_rule_v2(enum ipa_ip_type ip,`
`63`	`63`	`pipe_idx = ipa2_get_ep_mapping(entry->rule.dst);`
`64`	`64`	`if (pipe_idx == -1) {`
`65`	`65`	`IPAERR("Wrong destination pipe specified in RT rule\n");`
`66`		`- WARN_ON(1);`
	`66`	`+ WARN_ON_ONCE(1);`
`67`	`67`	`return -EPERM;`
`68`	`68`	`}`
`69`	`69`	`if (!IPA_CLIENT_IS_CONS(entry->rule.dst)) {`