refactor(coat/taoc): extract colorLines function; remove pipe w…

…hen naked `cat` 🐈
oldratlee · Jan 24, 2024 · adefc1a · adefc1a
1 parent a38e59f
commit adefc1a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 10 deletions.
diff --git a/bin/coat b/bin/coat
@@ -30,8 +30,16 @@ rotateColorPrint() {
   fi
 }
 
-# Bash read line does not read leading spaces
-# https://stackoverflow.com/questions/29689172
-cat "$@" | while IFS= read -r line; do
-  rotateColorPrint "$line"
-done
+colorLines() {
+  # Bash read line does not read leading spaces
+  # https://stackoverflow.com/questions/29689172
+  while IFS= read -r line; do
+    rotateColorPrint "$line"
+  done
+}
+
+if [ $# == 0 ]; then
+  colorLines
+else
+  cat "$@" | colorLines
+fi
diff --git a/bin/taoc b/bin/taoc
@@ -30,8 +30,12 @@ rotateColorPrint() {
   fi
 }
 
-# Bash read line does not read leading spaces
-# https://stackoverflow.com/questions/29689172
-tac "$@" | while IFS= read -r line; do
-  rotateColorPrint "$line"
-done
+colorLines() {
+  # Bash read line does not read leading spaces
+  # https://stackoverflow.com/questions/29689172
+  while IFS= read -r line; do
+    rotateColorPrint "$line"
+  done
+}
+
+tac "$@" | colorLines