Refactor for ruby 3 keyword argument syntax compatibility

Author: oleander

.rubocop_todo.yml

@@ -0,0 +1,23 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2024-11-15 06:22:54 UTC using RuboCop version 1.24.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: anonymous, explicit
+Naming/BlockForwarding:
+  Exclude:
+    - 'lib/git_fame/diff.rb'
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+# SupportedShorthandSyntax: always, never
+Style/HashSyntax:
+  EnforcedStyle: ruby19

lib/git_fame/collector.rb

@@ -9,7 +9,7 @@ class Collector
 
     # @return [Collector]
     def call
-      Result.new(contributions: contributions)
+      Result.new(contributions:)
     end
 
     private
@@ -36,7 +36,7 @@ def contributions
           files: files[email],
           author: {
             name: names[email],
-            email: email
+            email:
           }
         })
       end

lib/git_fame/command.rb

@@ -125,7 +125,7 @@ def run
       end
 
       thread = spinner.run do
-        Render.new(result: result, **options(:branch))
+        Render.new(result:, **options(:branch))
       end
 
       thread.value.call
@@ -150,11 +150,11 @@ def repo
     end
 
     def collector
-      Collector.new(filter: filter, diff: diff, **options)
+      Collector.new(filter:, diff:, **options)
     end
 
     def diff
-      Diff.new(commit: commit, **options)
+      Diff.new(commit:, **options)
     end
 
     def options(*args)

lib/git_fame/diff.rb

@@ -11,11 +11,11 @@ class Diff < Base
     # @yield [Hash]
     #
     # @return [void]
-    def each(&block)
+    def each(&)
       tree.walk(:preorder).each do |root, entry|
         case entry
         in { type: :blob, name: file, oid: }
-          Rugged::Blame.new(repo, root + file, newest_commit: commit).each(&block)
+          Rugged::Blame.new(repo, root + file, newest_commit: commit).each(&)
         in { type: type, name: file }
           say("Ignore type [%s] in for %s", type, root + file)
         end

lib/git_fame/render.rb

@@ -26,7 +26,7 @@ def call
         table << [c.name, c.email, c.lines.f, c.commits.count.f, c.files.count.f, c.dist(self)]
       end
 
-      print table.render(:unicode, width: width, resize: true, alignment: [:center])
+      print table.render(:unicode, width:, resize: true, alignment: [:center])
     end
 
     private

spec/filter_spec.rb

@@ -10,13 +10,13 @@
           include: Set["test*{.rb, .js, .ts}"],
           extensions: Set[".rb", ".js"],
           exclude: Set["*_spec.rb"],
-          before: before,
-          after: after
+          before:,
+          after:
         })
       end
 
       let(:now) { DateTime.now }
-      let(:changes) { super().deep_merge(orig_path: file_path, final_signature: { time: time }) }
+      let(:changes) { super().deep_merge(orig_path: file_path, final_signature: { time: }) }
       let(:file_path) { "test.rb" }
       let(:time) { Time.now }
       let(:before) { now + 1_000 }
@@ -39,9 +39,9 @@
     end
 
     context "when the before filter is set to today" do
-      subject(:filter) { build(:filter, before: before) }
+      subject(:filter) { build(:filter, before:) }
 
-      let(:changes) { super().deep_merge(final_signature: { time: time }) }
+      let(:changes) { super().deep_merge(final_signature: { time: }) }
       let(:before) { DateTime.now }
 
       context "when the change is set BEFORE the [before] filter" do
@@ -62,7 +62,7 @@
     end
 
     context "when the [exclude] filter is set to ignore [LI*ENCE]" do
-      subject(:filter) { build(:filter, exclude: exclude) }
+      subject(:filter) { build(:filter, exclude:) }
 
       let(:changes) { super().deep_merge(orig_path: file_path) }
       let(:exclude) { Set["LI*ENCE"] }
@@ -85,7 +85,7 @@
     end
 
     context "when the [include] filter is set to include [*_spec.rb]" do
-      subject(:filter) { build(:filter, include: include) }
+      subject(:filter) { build(:filter, include:) }
 
       let(:changes) { super().deep_merge(orig_path: file_path) }
       let(:include) { Set["*_spec.rb"] }
@@ -108,7 +108,7 @@
     end
 
     context "when the [extensions] filter is set to ignore [.rb]" do
-      subject(:filter) { build(:filter, extensions: extensions) }
+      subject(:filter) { build(:filter, extensions:) }
 
       let(:changes) { super().deep_merge(orig_path: file_path) }
       let(:extensions) { Set[".rb"] }
@@ -131,9 +131,9 @@
     end
 
     context "when the after filter is set to today" do
-      subject(:filter) { build(:filter, after: after) }
+      subject(:filter) { build(:filter, after:) }
 
-      let(:changes) { super().deep_merge(final_signature: { time: time }) }
+      let(:changes) { super().deep_merge(final_signature: { time: }) }
       let(:after) { DateTime.now }
 
       context "when the change is set BEFORE the after filter" do