refactor: make NoteSlugDTO type as string alias

Author: olexsmir

internal/dtos/note.go

@@ -6,9 +6,7 @@ import (
 	"github.com/gofrs/uuid/v5"
 )
 
-type NoteSlugDTO string
-
-func (n NoteSlugDTO) String() string { return string(n) }
+type NoteSlugDTO = string
 
 type NoteDTO struct {
 	Content              string

internal/service/notesrv/notesrv.go

@@ -44,12 +44,12 @@ func (n *NoteSrv) Create(
 	}
 
 	if !userID.IsNil() {
-		if err := n.noterepo.SetAuthorIDBySlug(ctx, dtos.NoteSlugDTO(inp.Slug), userID); err != nil {
+		if err := n.noterepo.SetAuthorIDBySlug(ctx, inp.Slug, userID); err != nil {
 			return "", err
 		}
 	}
 
-	return dtos.NoteSlugDTO(inp.Slug), nil
+	return inp.Slug, nil
 }
 
 func (n *NoteSrv) GetBySlugAndRemoveIfNeeded(
@@ -79,5 +79,5 @@ func (n *NoteSrv) GetBySlugAndRemoveIfNeeded(
 
 	// TODO: in future not remove, leave some metadata
 	// to shot user that note was alreasy seen
-	return note, n.noterepo.DeleteBySlug(ctx, dtos.NoteSlugDTO(note.Slug))
+	return note, n.noterepo.DeleteBySlug(ctx, note.Slug)
 }

internal/store/psql/noterepo/noterepo.go

@@ -98,7 +98,7 @@ func (s *NoteRepo) SetAuthorIDBySlug(
 	defer tx.Rollback(ctx) //nolint:errcheck
 
 	var noteID uuid.UUID
-	err = tx.QueryRow(ctx, "select id from notes where slug = $1", slug.String()).Scan(&noteID)
+	err = tx.QueryRow(ctx, "select id from notes where slug = $1", slug).Scan(&noteID)
 	if err != nil {
 		if errors.Is(err, pgx.ErrNoRows) {
 			return models.ErrNoteNotFound

internal/transport/http/apiv1/note.go

@@ -53,7 +53,7 @@ func (a *APIV1) createNoteHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusCreated, createNoteResponse{slug.String()})
+	c.JSON(http.StatusCreated, createNoteResponse{slug})
 }
 
 type getNoteBySlugResponse struct {
@@ -64,7 +64,7 @@ type getNoteBySlugResponse struct {
 
 func (a *APIV1) getNoteBySlugHandler(c *gin.Context) {
 	slug := c.Param("slug")
-	note, err := a.notesrv.GetBySlugAndRemoveIfNeeded(c.Request.Context(), dtos.NoteSlugDTO(slug))
+	note, err := a.notesrv.GetBySlugAndRemoveIfNeeded(c.Request.Context(), slug)
 	if err != nil {
 		errorResponse(c, err)
 		return