Skip to content
This repository was archived by the owner on Jul 31, 2024. It is now read-only.

Commit 0cea080

Browse files
author
vikas-cldcvr
committed
FLOW-1037 null svg element check added
1 parent 5efa280 commit 0cea080

File tree

2 files changed

+24
-20
lines changed

2 files changed

+24
-20
lines changed

packages/flow-lineage/src/components/f-lineage/f-lineage.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -624,12 +624,16 @@ export class FLineage extends FRoot {
624624
/* eslint-disable @typescript-eslint/no-unused-vars */
625625
/* eslint-disable @typescript-eslint/ban-ts-comment */
626626
// @ts-ignore
627-
doTemplateHotUpdate(node: LineageNodeElement, nodeSVGElement: HTMLElement, isChildNode = false) {
627+
doTemplateHotUpdate(
628+
node: LineageNodeElement,
629+
nodeSVGElement: HTMLElement | null,
630+
isChildNode = false
631+
) {
628632
try {
629633
if (isChildNode) {
630-
if (node.fNodeTemplate) {
634+
if (node.fNodeTemplate && nodeSVGElement) {
631635
render(node.fNodeTemplate(node), nodeSVGElement);
632-
} else if (this["children-node-template"]) {
636+
} else if (this["children-node-template"] && nodeSVGElement) {
633637
render(this["children-node-template"](node), nodeSVGElement);
634638
}
635639
} else {
@@ -639,9 +643,9 @@ export class FLineage extends FRoot {
639643
} else {
640644
node.childrenToggle = html``;
641645
}
642-
if (node.fNodeTemplate) {
646+
if (node.fNodeTemplate && nodeSVGElement) {
643647
render(node.fNodeTemplate(node), nodeSVGElement);
644-
} else if (this["node-template"]) {
648+
} else if (this["node-template"] && nodeSVGElement) {
645649
render(this["node-template"](node), nodeSVGElement);
646650
}
647651
}

stories/flow-lineage/lineage-properties.mdx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -500,13 +500,13 @@ node-id-1: { //Unique node id for each node
500500

501501
Each node is identified by a unique ID.
502502

503-
<div class="split">
503+
<div className="split">
504504
<div>
505-
<div class="title">Node example</div>
505+
<div className="title">Node example</div>
506506
<img src={imageFile} />
507507
</div>
508508
<div>
509-
<div class="title">Node data example</div>
509+
<div className="title">Node data example</div>
510510
<pre>
511511
<code>{`tony: { //Unique node ID
512512
fData: {
@@ -524,13 +524,13 @@ Each node is identified by a unique ID.
524524

525525
Nodes are represented through templates, you can pass custom markup to create a custom nodes.
526526

527-
<div class="split">
527+
<div className="split">
528528
<div>
529-
<div class="title">Node example</div>
529+
<div className="title">Node example</div>
530530
<img src={nodeTemplateImg} />
531531
</div>
532532
<div>
533-
<div class="title">Node data example</div>
533+
<div className="title">Node data example</div>
534534
<pre>
535535
<code>{`tony: {
536536
fNodeTemplate:\`<f-div direction="secondary" width="100%" height="hug-content" align="top-left">
@@ -552,13 +552,13 @@ The data required by each node needs to be present in the node schema.
552552

553553
###### Note: Use “\$\{node.data.key}” to access fData in your node template.
554554

555-
<div class="split">
555+
<div className="split">
556556
<div>
557-
<div class="title">Node example</div>
557+
<div className="title">Node example</div>
558558
<img src={templateDataImg} />
559559
</div>
560560
<div>
561-
<div class="title">Node data example</div>
561+
<div className="title">Node data example</div>
562562
<pre>
563563
<code>{`tony: {
564564
fData: { //Data goes here
@@ -577,13 +577,13 @@ The data required by each node needs to be present in the node schema.
577577

578578
Each node can have fChildren.
579579

580-
<div class="split">
580+
<div className="split">
581581
<div>
582-
<div class="title">Node example</div>
582+
<div className="title">Node example</div>
583583
<img src={childrenImg} />
584584
</div>
585585
<div>
586-
<div class="title">Node data example</div>
586+
<div className="title">Node data example</div>
587587
<pre>
588588
<code>
589589
{`tony: { //Unique node ID
@@ -613,12 +613,12 @@ Boolean that defines whether node children will be visible on load or not.
613613

614614
###### Note: On load, all node children are collpased/hidden. Clicking on a node will reveal its children
615615

616-
<div class="split">
616+
<div className="split">
617617
<div>
618-
<div class="title">Node example</div>
618+
<div className="title">Node example</div>
619619
</div>
620620
<div>
621-
<div class="title">Node data example</div>
621+
<div className="title">Node data example</div>
622622
<pre>add code here</pre>
623623
</div>
624624
</div>

0 commit comments

Comments
 (0)