Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method OmiseCardList@retrieve use empty key #160

Open
zhichao-poper opened this issue Nov 14, 2023 · 1 comment
Open

method OmiseCardList@retrieve use empty key #160

zhichao-poper opened this issue Nov 14, 2023 · 1 comment
Assignees

Comments

@zhichao-poper
Copy link

zhichao-poper commented Nov 14, 2023

Code like this:

        $omise_id = 'cust_test_111';
        $omise_public = 'pkey_test_111';
        $omise_secret = 'skey_test_111';
        $card_id = 'card_test_111';
        $customer = OmiseCustomer::retrieve($omise_id, $omise_public, $omise_secret);
        $card = $customer->cards()->retrieve($card_id);

$customer->cards() will return new OmiseCardList, and set $publickey & $secretkey to it.

however, it didn't call self::getInstance to set $instances array with keys, when $customer->cards()->retrieve (OmiseCardList@retrieve) , here call self::getResourceKey(), will receive empty or ENV key, not code var key.

Please make sure if this is a bug or a problem with my code.

omise-php 2.17.0
php 8.2

@aashishgurung
Copy link
Contributor

@zhichao-poper Thanks for reaching out. We will look into this and let you know about our findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants