Add DependencyInstantiationException

Author: omkar-tenkale

nodal/src/androidUnitTest/kotlin/dev/omkartenkale/nodal/NodeDependenciesTest.kt

@@ -1,23 +1,15 @@
 package dev.omkartenkale.nodal
 
+import dev.omkartenkale.nodal.exceptions.DependencyInstantiationException
 import dev.omkartenkale.nodal.exceptions.DependencyNotFoundException
-import dev.omkartenkale.nodal.exceptions.DependencyRedeclarationException
-import dev.omkartenkale.nodal.exceptions.NodeCreationException
-import dev.omkartenkale.nodal.plugin.NodalPlugins
 import dev.omkartenkale.nodal.util.MainDispatcherRule
-import dev.omkartenkale.nodal.util.assertDoesNotThrowException
-import dev.omkartenkale.nodal.util.assertNestedException
-import kotlinx.coroutines.ExperimentalCoroutinesApi
-import kotlinx.coroutines.test.currentTime
 import kotlinx.coroutines.test.runTest
-import kotlinx.coroutines.yield
-import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertFails
 import kotlin.test.assertFailsWith
-import kotlin.test.assertNotEquals
+import kotlin.test.assertNotNull
 import kotlin.test.fail
 
 class NodeDependenciesTest {
@@ -120,5 +112,33 @@ class NodeDependenciesTest {
         }
     }
 
+    @Test
+    fun `verify parameter dependency can be resolved`(){
+        class Foo(val value: Int)
+        class Bar(val foo: Foo)
+        class RootNode : Node()
+
+        val rootNode = Node.createRootNode(klass = RootNode::class, onRequestRemove = { }) {
+            provides { Foo(111) }
+            provides { Bar(get()) }
+        } as RootNode
+
+        assertEquals(rootNode.dependencies.get<Bar>().foo.value, 111)
+    }
+
+    @Test
+    fun `verify parameter dependency can be resolved if error`(){
+        class Foo
+        class Bar(val foo: Foo)
+        class RootNode : Node()
+
+        val rootNode = Node.createRootNode(klass = RootNode::class, onRequestRemove = { }) {
+            provides { Bar(get()) }
+        } as RootNode
+
+        assertFailsWith<DependencyInstantiationException>(){
+            rootNode.dependencies.get<Bar>().foo
+        }
+    }
 
 }

nodal/src/commonMain/kotlin/dev.omkartenkale.nodal/Scope.kt

@@ -1,5 +1,6 @@
 package dev.omkartenkale.nodal
 
+import dev.omkartenkale.nodal.exceptions.DependencyInstantiationException
 import dev.omkartenkale.nodal.exceptions.DependencyNotFoundException
 import dev.omkartenkale.nodal.exceptions.DependencyRedeclarationException
 import org.koin.core.KoinApplication
@@ -8,6 +9,7 @@ import org.koin.core.definition.BeanDefinition
 import org.koin.core.definition.Kind
 import org.koin.core.definition.indexKey
 import org.koin.core.error.DefinitionOverrideException
+import org.koin.core.error.InstanceCreationException
 import org.koin.core.error.NoDefinitionFoundException
 import org.koin.core.instance.ScopedInstanceFactory
 import org.koin.core.logger.Level
@@ -92,6 +94,8 @@ public class Scope(public val name: String, public val koinScope: KoinScope, pub
                 }
             }
             throw e
+        }catch (e: InstanceCreationException) {
+            throw DependencyInstantiationException(e)
         }
     }
 

nodal/src/commonMain/kotlin/dev.omkartenkale.nodal/exceptions/DependencyInstantiationException.kt

@@ -0,0 +1,3 @@
+package dev.omkartenkale.nodal.exceptions
+
+public class DependencyInstantiationException(t: Throwable) : NodalException("Failed to instantiate node's dependency", t)