Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPU package dependencies #26

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Remove GPU package dependencies #26

merged 11 commits into from
Jan 29, 2024

Conversation

omlins
Copy link
Owner

@omlins omlins commented Jan 26, 2024

The current state of Julia's extensions feature does not seem to provide a good way to make type aliases from the extensions available to the user (see #25 ). Given that type aliases are the only feature of CellArrays that actually require to import the GPU packages and therefore to create a dependency, we can provide the corresponding functionality using macros instead and then completely remove the GPU package dependencies.

@omlins
Copy link
Owner Author

omlins commented Jan 26, 2024

CC: @albert-de-montserrat

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1a4ed60) 63.56% compared to head (b701ea6) 74.38%.

Files Patch % Lines
src/CellArray.jl 80.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   63.56%   74.38%   +10.81%     
===========================================
  Files           3        3               
  Lines         129      121        -8     
===========================================
+ Hits           82       90        +8     
+ Misses         47       31       -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omlins omlins merged commit 4da63dc into main Jan 29, 2024
10 checks passed
@omlins omlins deleted the deps branch January 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants