Skip to content

text fix#593

Merged
mohandholu43 merged 1 commit intomasterfrom
fix/onprem-copilot-text
Mar 24, 2025
Merged

text fix#593
mohandholu43 merged 1 commit intomasterfrom
fix/onprem-copilot-text

Conversation

@mohandholu43
Copy link
Copy Markdown
Contributor

@mohandholu43 mohandholu43 commented Mar 24, 2025

Summary by CodeRabbit

  • Refactor
    • Updated the account configuration dialogs to consistently display service provider information instead of the previous terminology. This change improves the clarity of account connection and disconnection messages presented to users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2025

Walkthrough

This pull request updates the naming convention used in several components. The CloudAccountsPage now passes the property serviceProviderName (sourced from selectedInstanceOffering) instead of serviceOrgName (from selectedInstanceSubscription). In the ConnectAccountConfigDialog and DisconnectAccountConfigDialog components, as well as their nested sub-components, all instances of the serviceOrgName parameter/prop have been renamed to serviceProviderName. The modifications ensure consistent naming across these components without altering the overall functionality.

Changes

File(s) Summary
app/.../cloud-accounts/page.tsx Updated in CloudAccountsPage: renamed serviceOrgName to serviceProviderName and changed the value source from selectedInstanceSubscription to selectedInstanceOffering.
src/.../AccountConfigDialog/{Connect,Disconnect}AccountConfigDialog.jsx Renamed property/parameter in the Trigger and Run components, as well as in the dialog functions, from serviceOrgName to serviceProviderName.

Possibly related PRs

Suggested reviewers

  • Nithishprem

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64ba9ad and 6a1d9ff.

📒 Files selected for processing (3)
  • app/(dashboard)/cloud-accounts/page.tsx (2 hunks)
  • src/components/AccountConfigDialog/ConnectAccountConfigDialog.jsx (7 hunks)
  • src/components/AccountConfigDialog/DisconnectAccountConfigDialog.jsx (7 hunks)
🧰 Additional context used
🧬 Code Definitions (2)
src/components/AccountConfigDialog/DisconnectAccountConfigDialog.jsx (1)
src/components/AccountConfigDialog/ConnectAccountConfigDialog.jsx (2)
  • Trigger (174-228)
  • formik (470-484)
src/components/AccountConfigDialog/ConnectAccountConfigDialog.jsx (1)
src/components/AccountConfigDialog/DisconnectAccountConfigDialog.jsx (2)
  • Trigger (173-227)
  • formik (478-492)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: package
🔇 Additional comments (16)
app/(dashboard)/cloud-accounts/page.tsx (2)

612-612: Property name change for consistency

The property passed to the ConnectAccountConfigDialog component has been renamed from serviceOrgName to serviceProviderName, and now sources its value from selectedInstanceOffering?.serviceProviderName instead of selectedInstanceSubscription?.serviceOrgName.


626-626: Property name change for consistency

The property passed to the DisconnectAccountConfigDialog component has been renamed from serviceOrgName to serviceProviderName, and now sources its value from selectedInstanceOffering?.serviceProviderName instead of selectedInstanceSubscription?.serviceOrgName.

src/components/AccountConfigDialog/ConnectAccountConfigDialog.jsx (7)

174-174: Parameter name updated for better semantic clarity

The Trigger component's parameter has been renamed from serviceOrgName to serviceProviderName to better reflect its purpose.


197-199: Updated text to use new parameter name

The text message now references serviceProviderName instead of serviceOrgName while maintaining the same meaning.


230-236: Parameter name updated in Run component

The Run component's parameter has been updated from serviceOrgName to serviceProviderName for consistency.


302-303: Updated template text to use new parameter name

The text in the CloudFormation template instruction now references serviceProviderName instead of serviceOrgName.


427-429: Updated prop name in main component

The ConnectAccountConfigDialog function's destructured props now includes serviceProviderName instead of serviceOrgName for consistency with the rest of the changes.


507-507: Updated prop passing to Trigger component

The prop passed to the Trigger component now uses the renamed serviceProviderName parameter.


516-516: Updated prop passing to Run component

The prop passed to the Run component now uses the renamed serviceProviderName parameter.

src/components/AccountConfigDialog/DisconnectAccountConfigDialog.jsx (7)

173-173: Parameter name updated for better semantic clarity

The Trigger component's parameter has been renamed from serviceOrgName to serviceProviderName to better reflect its purpose.


197-199: Updated text to use new parameter name

The text message now references serviceProviderName instead of serviceOrgName while maintaining the same meaning.


235-235: Parameter name updated in Run component

The Run component's parameter has been updated from serviceOrgName to serviceProviderName for consistency.


305-305: Updated template text to use new parameter name

The text in the CloudFormation template instruction now references serviceProviderName instead of serviceOrgName.


431-431: Updated prop name in main component

The DisconnectAccountConfigDialog function's destructured props now includes serviceProviderName instead of serviceOrgName for consistency with the rest of the changes.


513-516: Updated prop passing to Trigger component

The prop passed to the Trigger component now uses the renamed serviceProviderName parameter.


525-525: Updated prop passing to Run component

The prop passed to the Run component now uses the renamed serviceProviderName parameter.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mohandholu43 mohandholu43 merged commit 61b4f18 into master Mar 24, 2025
6 checks passed
@mohandholu43 mohandholu43 deleted the fix/onprem-copilot-text branch March 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants