Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack does not like the crc check #21

Closed
jetersen opened this issue Oct 4, 2023 · 5 comments
Closed

Slack does not like the crc check #21

jetersen opened this issue Oct 4, 2023 · 5 comments

Comments

@jetersen
Copy link

jetersen commented Oct 4, 2023

Slack does not like the image: This image is a bit too big, even after resizing. A smaller file might help?

The size of the file is less than 128kb so I assume it has do with the image dimensions which is 259x202 it is crc check that fails.

This is the one I tried with using the github.io page.

old-man-yells-at-teamcity

Use this target for the generator 

teamcity

@oncilla
Copy link
Owner

oncilla commented Oct 4, 2023

Hi @jetersen. Thanks for reporting.

I wonder if this is related to #20.
If you use the CLI, does it happen too?

@jetersen
Copy link
Author

jetersen commented Oct 4, 2023

@oncilla Yes it seems like that would be the case 👍

The cli output works just fine.

@jetersen jetersen changed the title Slack does not like the image dimensions Slack does not like the crc check Oct 4, 2023
@oncilla
Copy link
Owner

oncilla commented Oct 4, 2023

Ack. Thanks for checking it out.

Currently I'm unsure what the issue is. The webassembly and cli code should be exactly the same.
I will need to dig a bit when I get around to it.

@oncilla
Copy link
Owner

oncilla commented Nov 14, 2023

Hi @jetersen

This should be fixed by #22. Could you double check if it is working now?

@jetersen
Copy link
Author

@oncilla Yes! I can confirm that it works 👏 I am able to add it to slack 👍

image

The -too is the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants