Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug for Filtration time, impossible to use more than ~17h #32

Open
roumano opened this issue Jul 21, 2023 · 2 comments
Open

Bug for Filtration time, impossible to use more than ~17h #32

roumano opened this issue Jul 21, 2023 · 2 comments

Comments

@roumano
Copy link

roumano commented Jul 21, 2023

Version of the custom_component

i'm using the dev version of this extension

Configuration

pool_pump:
  switch_entity_id: switch.pompe_piscine
  pool_pump_mode_entity_id: input_select.pool_pump_mode
  pool_temperature_entity_id: sensor.piscine_filtrage
  schedule_break_in_hours: 0.0

Describe the bug

it's impossible to filter more than around 17-18 hours due to pivot attribute and 1/3 before, 2/3 after.
as example value, today :

  • The pool temperature is 28°C
  • Pool_pump calculate a need of 18h26 of filtration
  • The pivot is define automaticaly to 13h42
  • "only" 1/3 of 18h26 was made on the morning (before the pivot)
  • So pool pump is planned to filter from 13h43 to 02h00 this afternoon

But at midnight, the pool_pump calculate a new filtration need as it's a new day and the automation every 15minutes of pool_pump stop the filtration

So today it will be filtering around 16h26 instead of 18h26 expected

For me, it's a important bug as it can result important consequence on the water due to lack of filtration when it's very hot.
roumano pushed a commit to roumano/pypool-pump that referenced this issue Sep 27, 2023
Fix Bug for Filtration time, impossible to use more than ~17h
b6ac818 
Fixing issue #32 ( oncleben31/ha-pool_pump#32
)

if end_time (start_time + duration) > 23h59 ; do
then :
  set end_time to 00h00
  move start_time earlier :
```
self._start_time = self._start_time - ( self.start_time + timedelta(hours=self.duration) - datetime.combine(self.start_time + timedelta(hours=self.duration), datetime.min.time()) )
```
roumano pushed a commit to roumano/pypool-pump that referenced this issue Sep 27, 2023
Fix issue #32 ( oncleben31/ha-pool_pump#32 )
94c3f82
@roumano roumano mentioned this issue Sep 27, 2023
Open
@roumano
Copy link
Author

roumano commented Dec 17, 2023

Can you review my merge request in pypool-pump repo ?
Regards

@roumano
Copy link
Author

roumano commented Apr 22, 2024

Hi,
It's frustrating to not get news since several months

Can you review my merge request in pypool-pump repo ? ( cf oncleben31/pypool-pump#5 )
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roumano