Skip to content

Commit f71ef62

Browse files
committed
Fix passing struct object by value
Don't pass large objects by value, use a r-value reference instead. Also make function defined in header `inline`.
1 parent b841691 commit f71ef62

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/adapters/level_zero/event_cache_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ static std::shared_ptr<_zel_tracer_handle_t> tracer = [] {
3030
zel_core_callbacks_t prologue_callbacks{};
3131
prologue_callbacks.Event.pfnCreateCb = OnEnterEventCreate;
3232
prologue_callbacks.Event.pfnDestroyCb = OnEnterEventDestroy;
33-
return enableTracing(prologue_callbacks, {});
33+
return enableTracing(std::move(prologue_callbacks), {});
3434
}();
3535

3636
template <typename... Args> auto combineFlags(std::tuple<Args...> tuple) {

test/adapters/level_zero/multi_device_event_cache_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ static std::shared_ptr<_zel_tracer_handle_t> tracer = [] {
2020
zel_core_callbacks_t prologue_callbacks{};
2121
prologue_callbacks.CommandList.pfnAppendWaitOnEventsCb =
2222
OnAppendWaitOnEventsCb;
23-
return enableTracing(prologue_callbacks, {});
23+
return enableTracing(std::move(prologue_callbacks), {});
2424
}();
2525

2626
using urMultiQueueMultiDeviceEventCacheTest = uur::urAllDevicesTest;

test/adapters/level_zero/ze_tracer_common.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111

1212
#include <memory>
1313

14-
std::shared_ptr<_zel_tracer_handle_t>
15-
enableTracing(zel_core_callbacks_t prologueCallbacks,
16-
zel_core_callbacks_t epilogueCallbacks) {
14+
inline std::shared_ptr<_zel_tracer_handle_t>
15+
enableTracing(zel_core_callbacks_t &&prologueCallbacks,
16+
zel_core_callbacks_t &&epilogueCallbacks) {
1717
EXPECT_EQ(zeInit(ZE_INIT_FLAG_GPU_ONLY), ZE_RESULT_SUCCESS);
1818

1919
zel_tracer_desc_t tracer_desc = {ZEL_STRUCTURE_TYPE_TRACER_EXP_DESC, nullptr,

0 commit comments

Comments
 (0)