Skip to content

Commit dbe46e6

Browse files
authored
Merge pull request #6931 from onflow/petera/reduce-provider-logging-v0.37
[Collection] Reduce log level in provider
2 parents 9eb49cc + fea0e4f commit dbe46e6

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

engine/common/provider/engine.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,14 @@ func (e *Engine) processEntityRequestWorker(ctx irrecoverable.SignalerContext, r
343343
lg.Trace().Msg("worker picked up entity request for processing")
344344
err := e.onEntityRequest(request)
345345
if err != nil {
346-
if engine.IsInvalidInputError(err) || engine.IsNetworkTransmissionError(err) {
347-
lg.Error().Err(err).Msg("worker could not process entity request")
346+
if engine.IsInvalidInputError(err) {
347+
// log at debug level since nodes that recently unstaked are allowed to communicate over
348+
// the network, but not allowed to request entities. Even an honest node may have been
349+
// behind processing blocks and inadvertently continue requesting entities after they
350+
// have left the network.
351+
lg.Debug().Err(err).Msg("could not process entity request: invalid request")
352+
} else if engine.IsNetworkTransmissionError(err) {
353+
lg.Error().Err(err).Msg("could not process entity request: transmit error")
348354
} else {
349355
// this is an unexpected error, we crash the node.
350356
ctx.Throw(err)

0 commit comments

Comments
 (0)