Skip to content

Commit ff8c3a9

Browse files
authored
Merge pull request #6848 from The-K-R-O-K/AndriiDiachuk/6837-hearbeat-interval-correct-reset
[Access] Heartbeat interval not reset correctly in streaming endpoints.
2 parents ce0396a + 1554d01 commit ff8c3a9

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

engine/access/rest/websockets/data_providers/account_statuses_provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ func (p *AccountStatusesDataProvider) handleResponse() func(accountStatusesRespo
109109
if blocksSinceLastMessage < p.heartbeatInterval {
110110
return nil
111111
}
112-
blocksSinceLastMessage = 0
113112
}
113+
blocksSinceLastMessage = 0
114114

115115
index := messageIndex.Value()
116116
if ok := messageIndex.Set(messageIndex.Value() + 1); !ok {

engine/access/rest/websockets/data_providers/events_provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ func (p *EventsDataProvider) handleResponse() func(eventsResponse *backend.Event
9595
if blocksSinceLastMessage < p.heartbeatInterval {
9696
return nil
9797
}
98-
blocksSinceLastMessage = 0
9998
}
99+
blocksSinceLastMessage = 0
100100

101101
index := messageIndex.Value()
102102
if ok := messageIndex.Set(messageIndex.Value() + 1); !ok {

engine/access/rest/websockets/legacy/websocket_handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ func (wsController *WebsocketController) writeEvents(sub subscription.Subscripti
146146
if blocksSinceLastMessage < wsController.HeartbeatInterval {
147147
continue
148148
}
149-
blocksSinceLastMessage = 0
150149
}
150+
blocksSinceLastMessage = 0
151151

152152
// EventsResponse contains CCF encoded events, and this API returns JSON-CDC events.
153153
// convert event payload formats.

engine/access/state_stream/backend/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,8 @@ func (h *Handler) handleEventsResponse(send sendSubscribeEventsResponseFunc, hea
370370
if blocksSinceLastMessage < heartbeatInterval {
371371
return nil
372372
}
373-
blocksSinceLastMessage = 0
374373
}
374+
blocksSinceLastMessage = 0
375375

376376
// BlockExecutionData contains CCF encoded events, and the Access API returns JSON-CDC events.
377377
// convert event payload formats.
@@ -490,8 +490,8 @@ func (h *Handler) handleAccountStatusesResponse(
490490
if blocksSinceLastMessage < heartbeatInterval {
491491
return nil
492492
}
493-
blocksSinceLastMessage = 0
494493
}
494+
blocksSinceLastMessage = 0
495495

496496
results, err := convertAccountsStatusesResultsToMessage(evenVersion, resp)
497497
if err != nil {

0 commit comments

Comments
 (0)