Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rosetta] Refactor testnet integration test script #60

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented May 21, 2024

How to test:

  • cd integration
  • python3 testnet_integration_test.py --init
  • follow script instructions

@illia-malachyn illia-malachyn changed the title Refactor testnet integration test script [Rosetta] Refactor testnet integration test script May 21, 2024
@illia-malachyn illia-malachyn marked this pull request as ready for review May 23, 2024 13:29
@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented May 23, 2024

I refactored only testnet_integration_test.py. There's also integration_test.py for testing against a local net and previewnet_integration_test.py is coming soon from Uliana's PR. They're pretty much similar, so as soon as her test is committed, I'll update both of them to make use of a new structure and functions to avoid code duplication

@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented May 23, 2024

I notice that the tests' transactions fail at some point on testnet. There's a screenshot from Flow Diver. It is not related to refactoring, rather it is related to the Crescendo upgrade.

@peterargue Do you know what the potential reason is?

Screenshot from 2024-05-23 12-42-26

@franklywatson franklywatson linked an issue May 23, 2024 that may be closed by this pull request
@peterargue
Copy link
Collaborator

As mentioned in standup, that error is most likely caused by a new feature on devnet that causes tx to fail that have not been upgraded to Cadence 1.0. I should be shut off now, so you can try again.

@illia-malachyn
Copy link
Contributor Author

Closing in favor of #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rosetta] Refactor integration tests
3 participants