Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brew version to check latest version #599

Closed
jribbink opened this issue Apr 25, 2024 · 0 comments · Fixed by #600
Closed

Use brew version to check latest version #599

jribbink opened this issue Apr 25, 2024 · 0 comments · Fixed by #600
Assignees

Comments

@jribbink
Copy link
Contributor

jribbink commented Apr 25, 2024

We should use homebrew instead since version.txt is being deprecated on the Flow CLI repo (see onflow/flow-cli#1545). Either use the formula on github or homebrew API (must check what availability is like? rate limits?).

There is an implicit guarantee that the shell script install method will at least support the same version that Homebrew does, since Homebrew is the limiting factor for version updates.

@jribbink jribbink self-assigned this Apr 25, 2024
@jribbink jribbink moved this to 👀 In Review in 🌊 Flow 4D Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant