Code review, cleanup, modernization

[biblicabeebli]

It is time to do some.... code review, cleanup, and modernization!

[biblicabeebli]

• there's going to be a set of big commits of style changes, typing changes.
• minimum python version to 3.8, will need to update documentation
• will be to shifting code out of init files
• style changes will now be based on.... my preferences, like retaining whitespace indents
• old style hinting inside comments is being removed in favor of inline python type hints
  • hm need to check what this does to sphinx
• couple things like triple """
• new line length policy is soft 100 chars
• anyone introducing black

[biblicabeebli]

I'm getting an error inside the download test where zipfileio thinks the file is not a valid zip.

I have manually extracted binary of the file, written it to a file, and it opens just fine with the mac os archive utility.
don't know what's up.

[biblicabeebli]

I've checked running tests in python 3.7 and 3.6, the error is raised inside python zipfile. Some detail affecting zipfile changed.

• zipfile is different in some respects, but the function that is now raising an error has changed, the function with signature def _EndRecData(fpin):
• there is a byte slicing data[0:4] that is returning different data.b'\xf2\xbf\xff\xce' on 3.8 and b'PK\x05\x06' on 3.7
• the filesize variable (after a .seek and a .tell on the BytesIO object) differ. 443,610 on 3.7, 97,409 on 3.8.
• Soooo the test fails due to an implementational difference of BytesIO in python 3.8. Oh goody.
• Nope, the data coming out of the (vcr'd) request itself is different.
• yup its some kind of vcrpy change. reverted to 4.4.0 and tests pass.
• it was a dependency that was getting set by vcrpy, but then somehow it got unset (I have no Idea how that works) and then python < 3.8 do not support library version 2.0.0+. The library? urllib3. ... ... ... I don't know and I don't care I spent a full work day on this and I'm done.

[biblicabeebli]

on pause while I clean up credentials and get other work done for new API endpoints