-
Notifications
You must be signed in to change notification settings - Fork 14
Create and upload source distributions to PyPI, use the newest cibuildwheel version
#467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s currently one major release behind)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 55 55
Lines 2636 2636
Branches 144 144
=======================================
Hits 2400 2400
Misses 163 163
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…stalls the correct version)
|
|
||
| - name: Install cibuildwheel | ||
| run: python -m pip install cibuildwheel==2.23.2 | ||
| run: python -m pip install cibuildwheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving it without version spec has both pros and cons:
- we are more likely to keep up to date with upstream releases
- we are risking PRs failing due to unrelated problems (i.e. due to changes in
cibuildwheelrather than due to chenges in a PR)
hard to tell, what is best in the context of PyPartMC (which does not have that many PRs and developers)
Addresses #465 and #466