Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should was_defendant_served return a dict? #76

Open
mscarey opened this issue May 14, 2021 · 0 comments
Open

should was_defendant_served return a dict? #76

mscarey opened this issue May 14, 2021 · 0 comments

Comments

@mscarey
Copy link
Collaborator

mscarey commented May 14, 2021

@funkonaut, I saw your comment asking why was_defendant_served should return a dict, and I saw that you changed Hays County to return a string while the other counties still return a dict in the form Dict[name, date]. I reverted the change because I think it's going to be a problem for the scraper to return different datatypes depending on what county is being scraped.

Based on the discussion in the issue tracker, it seems like this field might not be in use at all. As long as it returns consistent datatypes, it probably won't break anything. If you want to change the datatype, I think you should change it for every county at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant