Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: plugin installer #55

Closed
wants to merge 4 commits into from
Closed

WIP: plugin installer #55

wants to merge 4 commits into from

Conversation

derTobsch
Copy link
Member

@derTobsch derTobsch commented Jan 27, 2019 •
edited
Loading

closes #23

accesslint[bot]
accesslint bot suggested changes Jan 27, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/main/resources/templates/management/plugins.html
<span th:text="${version.name}"></span>

<form style="display: inline-block" th:action="@{/plugins-install}" th:method="put">
<input type="hidden" name="url" th:value="${version.url}"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

@derTobsch derTobsch changed the title WIP: Feature/plugin installer WIP: plugin installer Jan 27, 2019
@derTobsch derTobsch mentioned this pull request Jan 27, 2019
Open
@derTobsch derTobsch force-pushed the feature/plugin-installer branch 3 times, most recently from aa926c2 to 95a81e5 Compare March 22, 2020 19:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability E 2 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

41.5% 41.5% Coverage
0.0% 0.0% Duplication

@derTobsch derTobsch force-pushed the feature/plugin-installer branch from 74c3c01 to ad082e4 Compare May 25, 2020 14:29
@derTobsch derTobsch force-pushed the feature/plugin-installer branch from ad082e4 to 6217c38 Compare May 25, 2020 17:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability E 2 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

41.5% 41.5% Coverage
0.0% 0.0% Duplication

@derTobsch derTobsch closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add function to install plugins via the frontpage
1 participant
@derTobsch