-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor image for ocm toi must run as root #359
Comments
As a sidenote, I would stop using |
Hey Dan. Can you try with this PR please? open-component-model/ocm#1224 |
I actually run your project Dan and I didn't get your error. My output:
|
Hey @Skarlso Thanks for the quick response! :) I pulled down your change to apply Locally, I tried backing out our change and putting in the one the below and that seemed to fix the problem. Basically in the loop I just make sure we don't try making a dir entry for either '/' or '.'. This should be safe since we shouldn't have any need to alter the permissions of any containers that are already existing in the container and those two at least should be pre-existing. |
Yah I was looking at that too. And did that fix your permission issue? Just to be clear, I tried with latest OCM and NOT my PR because my pr was broken. :D And latest OCM worked with the output above. Did I run the correct command? Also, what is your For me, I just built the Dockerfile that you had there and pushed that and used it as is. Was that correct? |
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes Related to open-component-model/ocm-project#359 Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Hey @Skarlso So with your PR I ran into the issue I you mentioned here What I did after initially hitting that problem was :
And of course in the meantime you put those changes in place. :) Thanks! |
So... It works now? 🤔 |
Yep! |
Nice yay 🎉👍🤩🍻 |
What happened:
I found with the USER statement in the dockerfile below my executor could not run.
Running a command like
will fail with an error like
The problem is when ocm copies the inputs into the container it messes up the permissions on root. The screenshot below shows the change. On the left are the permissions after ocm copied the input into place and the right are the default permissions. You can see that afterwards the permissions on root only let the owner work with it.
What you expected to happen:
I should be able to have the container run as non-root.
Copying of inputs into the container should only modify the contents of under /toi/inputs.
The contents of /toi/inputs must be readable by whatever user the container is running as
How to reproduce it (as minimally and precisely as possible):
See above command and dockerfile.
Anything else we need to know:
Nope
Environment:
ocm 0.19.0
The text was updated successfully, but these errors were encountered: