Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll xblock not editable in edX #186

Open
jesperhodge opened this issue Jan 28, 2025 · 8 comments
Open

Poll xblock not editable in edX #186

jesperhodge opened this issue Jan 28, 2025 · 8 comments

Comments

@jesperhodge
Copy link

Hi Open Craft,
we (TNL at 2U) got a bug report saying the poll xblock in studio is not editable or closable after clicking the edit button.

The browser console just shows a call to https://studio.stage.edx.org/static/studio/xblock/resources/poll/public/js/vendor/handlebars.js that produces a 404 and a console error. Not sure if that's the cause.

This problem is reproducible in courses on edx:

  • Create a Poll component
  • Click Edit
  • Try to click on any of the 3 options: “Add Answer”, “Save” or “Cancel”

I have a video I can provide in slack, for some reason github is not allowing me to upload it.

Thanks so much for your support!

@Agrendalath
Copy link
Member

Hi @jesperhodge, the handlebars library is available at https://studio.stage.edx.org/xblock/resource/poll/public/js/vendor/handlebars.js. Therefore, it seems like the resources from this XBlock are not copied when collecting static files.

@kdmccormick, could this be related to openedx/edx-platform#32692? Are there any extra steps required if a non-core XBlock wants to provide some static resources?

@kdmccormick
Copy link
Contributor

I tried this on a Sumac test site (running via tutor local). Strangely, I encountered the problem as described only the first time I tried editing and saving a Poll block; since that one attempt, I can edit Poll blocks and save them without issue... I have even tried creating different Poll blocks and using a fresh cold-cache private browsing window.

@kdmccormick
Copy link
Contributor

kdmccormick commented Jan 31, 2025

Are there any extra steps required if a non-core XBlock wants to provide some static resources?

That particular PR should have only touched "xmodule" assets (assets for baked-in edx-platform xblocks). I would be surprised if it affected a proper xblock like xblock-poll.

We did rewrite the edx-platform asset processing scripts, and the new scripts have been used in Tutor as recently as Redwood, and on edx.org since early Jan 2025. We did not intend to make any changes to how xblock assets were collected from 3rd party packages, but a bug in the rewrite could certainly manifest in an asset collection problem.

@pdpinch
Copy link

pdpinch commented Feb 4, 2025

@jesperhodge we're seeing this too at MIT. Do you still think openedx/edx-platform#36044 (comment) needs to be reverted?

@kdmccormick
Copy link
Contributor

kdmccormick commented Feb 4, 2025

@jesperhodge I see that you are reluctant to merge the revert PR. Can you help me understand why? Generally speaking, when we have reason to believe that a merged PR is actively responsible for a bug, then that is sufficient justification for merging a revert--exhaustive verification is not necessary.

@kdmccormick
Copy link
Contributor

Based the Slack thread between @jesperhodge , @feanil, and @pdpinch in #ask-axim, it seems very likely that the PR in question is responsible for the bug. Personally I highly recommend reverting, but for the time being, I will leave it to 2U and MITx CCs to decide whether and when to hit Merge on the revert.

@pdpinch
Copy link

pdpinch commented Feb 7, 2025

@jesperhodge you OK with closing this?

@feanil
Copy link

feanil commented Feb 11, 2025

@Agrendalath I think you can close this, the issue was in an edx-platform PR which has been reverted and that did resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants