-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poll xblock not editable in edX #186
Comments
Hi @jesperhodge, the handlebars library is available at https://studio.stage.edx.org/xblock/resource/poll/public/js/vendor/handlebars.js. Therefore, it seems like the resources from this XBlock are not copied when collecting static files. @kdmccormick, could this be related to openedx/edx-platform#32692? Are there any extra steps required if a non-core XBlock wants to provide some static resources? |
I tried this on a Sumac test site (running via |
That particular PR should have only touched "xmodule" assets (assets for baked-in edx-platform xblocks). I would be surprised if it affected a proper xblock like xblock-poll. We did rewrite the edx-platform asset processing scripts, and the new scripts have been used in Tutor as recently as Redwood, and on edx.org since early Jan 2025. We did not intend to make any changes to how xblock assets were collected from 3rd party packages, but a bug in the rewrite could certainly manifest in an asset collection problem. |
@jesperhodge we're seeing this too at MIT. Do you still think openedx/edx-platform#36044 (comment) needs to be reverted? |
@jesperhodge I see that you are reluctant to merge the revert PR. Can you help me understand why? Generally speaking, when we have reason to believe that a merged PR is actively responsible for a bug, then that is sufficient justification for merging a revert--exhaustive verification is not necessary. |
Based the Slack thread between @jesperhodge , @feanil, and @pdpinch in |
@jesperhodge you OK with closing this? |
@Agrendalath I think you can close this, the issue was in an edx-platform PR which has been reverted and that did resolve the issue. |
Hi Open Craft,
we (TNL at 2U) got a bug report saying the poll xblock in studio is not editable or closable after clicking the edit button.
The browser console just shows a call to https://studio.stage.edx.org/static/studio/xblock/resources/poll/public/js/vendor/handlebars.js that produces a 404 and a console error. Not sure if that's the cause.
This problem is reproducible in courses on edx:
I have a video I can provide in slack, for some reason github is not allowing me to upload it.
Thanks so much for your support!
The text was updated successfully, but these errors were encountered: