Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document verifyParams #552

Open
1 task
pi0neerpat opened this issue Mar 25, 2024 · 2 comments
Open
1 task

Document verifyParams #552

pi0neerpat opened this issue Mar 25, 2024 · 2 comments
Labels
tech-debt

Comments

@pi0neerpat
Copy link
Member

pi0neerpat commented Mar 25, 2024 •
edited
Loading

  • Add readme instructions for scripts/postDeployment/verifyParams
@pi0neerpat pi0neerpat changed the title Document params validation script Document verifyParams Mar 25, 2024
@pi0neerpat pi0neerpat mentioned this issue Mar 27, 2024
Closed
2 tasks
@ngmachado
Copy link
Contributor

@pi0neerpat running the script against dev branch this is the output:

Script ran successfully.

== Logs ==
  SAFEEngineParams: incorrect safeDebtCeiling:  2000000000000000000000000
  SAFEEngineParams: desired safeDebtCeiling:  10000000000000000000000000
  AccountingEngineParams: incorrect surplusDelay:  1800
  AccountingEngineParams: desired surplusDelay:  86400
  AccountingEngineParams: incorrect popDebtDelay:  1800
  AccountingEngineParams: desired popDebtDelay:  86400
  DebtAuctionHouseParams: incorrect amountSoldIncrease:  1050000000000000000
  DebtAuctionHouseParams: desired amountSoldIncrease:  1500000000000000000
  DebtAuctionHouseParams: incorrect bidDuration:  900
  DebtAuctionHouseParams: desired bidDuration:  10800
  DebtAuctionHouseParams: incorrect totalAuctionLength:  1800
  DebtAuctionHouseParams: desired totalAuctionLength:  172800
  SurplusAuctionHouseParams: incorrect bidDuration:  900
  SurplusAuctionHouseParams: desired bidDuration:  3600
  SurplusAuctionHouseParams: incorrect bidReceiver:  0xB052d23F4Ffb146e48318b97fe9903b9e6D0ddC3
  SurplusAuctionHouseParams: desired bidReceiver:  0x0000000000000000000000000000000000000000
  SurplusAuctionHouseParams: incorrect totalAuctionLength:  1800
  SurplusAuctionHouseParams: desired totalAuctionLength:  86400
  SurplusAuctionHouseParams: incorrect recyclingPercentage:  50
  SurplusAuctionHouseParams: desired recyclingPercentage:  500000000000000000
  PostSettlementSAHParams: incorrect bidDuration:  900
  PostSettlementSAHParams: desired bidDuration:  10800
  PostSettlementSAHParams: incorrect totalAuctionLength:  1800
  PostSettlementSAHParams: desired totalAuctionLength:  172800
  incorrect minimumBid:  1000000000000000000
  desired minimumBid:  5000000000000000000
  incorrect max discount:  500000000000000000
  desired max discount:  1000000000000000000
  incorrect safetyCRatio:  1500000000000000000000000000
  desired safetyCRatio:  1400000000000000000000000000
  incorrect liquidationCRatio:  1500000000000000000000000000
  desired liquidationCRatio:  1350000000000000000000000000
  incorrect stabilityFee:  1000000011119260000000000000
  desired stabilityFee:  1000000000627857000000000000
  incorrect debtFloor:  1000000000000000000000000000000000000000000000
  desired debtFloor:  200000000000000000000000000000000000000000000000
  incorrect liquidationPenalty:  1200000000000000000
  desired liquidationPenalty:  1050000000000000000
  incorrect liquidationQuantity:  1000000000000000000000000000000000000000000000000
  desired liquidationQuantity:  100000000000000000000000000000000000000000000000000
  Collateral type  0  verified.
  incorrect minimumBid:  1000000000000000000
  desired minimumBid:  5000000000000000000
  incorrect max discount:  900000000000000000
  desired max discount:  1000000000000000000
  incorrect safetyCRatio:  1350000000000000000000000000
  desired safetyCRatio:  1250000000000000000000000000
  incorrect liquidationCRatio:  1350000000000000000000000000
  desired liquidationCRatio:  1200000000000000000000000000
  incorrect stabilityFee:  1000000001547130000000000000
  desired stabilityFee:  1000000011119260000000000000
  incorrect debtCeiling:  100000000000000000000000000000000000000000000000000000
  desired debtCeiling:  10000000000000000000000000000000000000000000000000000
  incorrect debtFloor:  1000000000000000000000000000000000000000000000
  desired debtFloor:  5000000000000000000000000000000000000000000000000
  incorrect liquidationPenalty:  1100000000000000000
  desired liquidationPenalty:  1150000000000000000
  incorrect liquidationQuantity:  1000000000000000000000000000000000000000000000000
  desired liquidationQuantity:  100000000000000000000000000000000000000000000000000
  Collateral type  1  verified.
  incorrect minimumBid:  1000000000000000000
  desired minimumBid:  5000000000000000000
  incorrect max discount:  900000000000000000
  desired max discount:  1000000000000000000
  incorrect safetyCRatio:  1500000000000000000000000000
  desired safetyCRatio:  1250000000000000000000000000
  incorrect liquidationCRatio:  1500000000000000000000000000
  desired liquidationCRatio:  1200000000000000000000000000
  incorrect stabilityFee:  1000000011119260000000000000
  desired stabilityFee:  1000000000627857000000000000
  incorrect debtFloor:  1000000000000000000000000000000000000000000000
  desired debtFloor:  200000000000000000000000000000000000000000000000
  incorrect liquidationPenalty:  1100000000000000000
  desired liquidationPenalty:  1050000000000000000
  incorrect liquidationQuantity:  1000000000000000000000000000000000000000000000000
  desired liquidationQuantity:  100000000000000000000000000000000000000000000000000
  Collateral type  2  verified.
  incorrect minimumBid:  1000000000000000000
  desired minimumBid:  5000000000000000000
  incorrect max discount:  900000000000000000
  desired max discount:  1000000000000000000
  incorrect safetyCRatio:  1500000000000000000000000000
  desired safetyCRatio:  1250000000000000000000000000
  incorrect liquidationCRatio:  1500000000000000000000000000
  desired liquidationCRatio:  1200000000000000000000000000
  incorrect stabilityFee:  1000000011119260000000000000
  desired stabilityFee:  1000000000627857000000000000
  incorrect debtFloor:  1000000000000000000000000000000000000000000000
  desired debtFloor:  200000000000000000000000000000000000000000000000
  incorrect liquidationPenalty:  1100000000000000000
  desired liquidationPenalty:  1050000000000000000
  incorrect liquidationQuantity:  1000000000000000000000000000000000000000000000000
  desired liquidationQuantity:  100000000000000000000000000000000000000000000000000
  Collateral type  3  verified.

@pi0neerpat
Copy link
Member Author

The output looks expected, since many changes were made since last sepolia deployment

@pi0neerpat pi0neerpat added ch-34 and removed ch-33 labels Apr 23, 2024
@pi0neerpat pi0neerpat removed the ch-35 label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ngmachado @pi0neerpat @MrDeadCe11