SIGA-255 fixed default values in tests for Smart-ID signing request

open-eid · Oct 9, 2020 · 25d9886 · 25d9886
1 parent a31e149
commit 25d9886
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/siga-test/src/test/java/ee/openeid/siga/test/asic/SmartIdSigningAsicContainerT.java b/siga-test/src/test/java/ee/openeid/siga/test/asic/SmartIdSigningAsicContainerT.java
@@ -316,7 +316,7 @@ public void signWithSmartIdNonExistingSignatureProfile() throws Exception {
     @Test
     public void signWithSmartIdInvalidRole() throws Exception {
         postCreateContainer(flow, asicContainersDataRequestWithDefault());
-        Response response = postSmartIdSigningInSession(flow, smartIdSigningRequest("EE", "LT", null, null, null, null, null, "", null));
+        Response response = postSmartIdSigningInSession(flow, smartIdSigningRequest("LT", null, null, null, null, null, "", null));
 
         expectError(response, 400, INVALID_REQUEST);
     }

diff --git a/siga-test/src/test/java/ee/openeid/siga/test/hashcode/SmartIdSigningHashcodeContainerT.java b/siga-test/src/test/java/ee/openeid/siga/test/hashcode/SmartIdSigningHashcodeContainerT.java
@@ -540,7 +540,7 @@ public void patchToHashcodeSmartIdCertificateStatus() throws NoSuchAlgorithmExce
     @Test
     public void signWithSmartIdInvalidRole() throws NoSuchAlgorithmException, InvalidKeyException, JSONException {
         postCreateContainer(flow, hashcodeContainersDataRequestWithDefault());
-        Response response = postSmartIdSigningInSession(flow, smartIdSigningRequest("EE", "LT", null, null, null, null, null, "",null));
+        Response response = postSmartIdSigningInSession(flow, smartIdSigningRequest("LT", null, null, null, null, null, "",null));
 
         expectError(response, 400, INVALID_REQUEST);
     }

diff --git a/siga-test/src/test/java/ee/openeid/siga/test/utils/RequestBuilder.java b/siga-test/src/test/java/ee/openeid/siga/test/utils/RequestBuilder.java
@@ -181,12 +181,11 @@ public static JSONObject smartIdCertificateChoiceRequest(String personIdentifier
         }
 
     public static JSONObject smartIdSigningRequestWithDefault(String signatureProfile, String documentNumber) throws JSONException {
-        return smartIdSigningRequest("EE", signatureProfile, documentNumber, "something", null, null,null, null, null);
+        return smartIdSigningRequest(signatureProfile, documentNumber, "something", null, null,null, null, null);
     }
 
-    public static JSONObject smartIdSigningRequest(String originCountry, String signatureProfile, String documentNumber, String messageToDisplay, String city, String stateOrProvince, String postalCode, String country, String roles) throws JSONException {
+    public static JSONObject smartIdSigningRequest(String signatureProfile, String documentNumber, String messageToDisplay, String city, String stateOrProvince, String postalCode, String country, String roles) throws JSONException {
         JSONObject request = new JSONObject();
-        request.put("country", originCountry);
         request.put("signatureProfile", signatureProfile);
         request.put("documentNumber", documentNumber);