From 1a46aea2422e6841a7909c01b8568450360477d7 Mon Sep 17 00:00:00 2001
From: Dave <89858058+DBlanchard88@users.noreply.github.com>
Date: Wed, 15 May 2024 13:18:33 -0400
Subject: [PATCH] fix: PMD warnings with new version (#936)

* chore(deps): update dependency org.apache.maven.plugins:maven-pmd-plugin to v3.22.0

* removed redundancy from eventdetails, SuppressWarnings in OpenfeatureAPI and Client

Signed-off-by: DBlanchard88 <davidblanchard88@gmail.com>

* Update src/main/java/dev/openfeature/sdk/OpenFeatureClient.java

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

---------

Signed-off-by: DBlanchard88 <davidblanchard88@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
---
 pom.xml                                                  | 2 +-
 src/main/java/dev/openfeature/sdk/EventDetails.java      | 4 ++--
 src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java    | 1 +
 src/main/java/dev/openfeature/sdk/OpenFeatureClient.java | 3 ++-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index e008548d3..a38e5297f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -334,7 +334,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-pmd-plugin</artifactId>
-        <version>3.21.2</version>
+        <version>3.22.0</version>
         <executions>
           <execution>
             <id>run-pmd</id>
diff --git a/src/main/java/dev/openfeature/sdk/EventDetails.java b/src/main/java/dev/openfeature/sdk/EventDetails.java
index 02b1964dd..08cb7e211 100644
--- a/src/main/java/dev/openfeature/sdk/EventDetails.java
+++ b/src/main/java/dev/openfeature/sdk/EventDetails.java
@@ -13,14 +13,14 @@ public class EventDetails extends ProviderEventDetails {
     private String providerName;
 
     static EventDetails fromProviderEventDetails(ProviderEventDetails providerEventDetails, String providerName) {
-        return EventDetails.fromProviderEventDetails(providerEventDetails, providerName, null);
+        return fromProviderEventDetails(providerEventDetails, providerName, null);
     }
 
     static EventDetails fromProviderEventDetails(
             ProviderEventDetails providerEventDetails,
             String providerName,
             String clientName) {
-        return EventDetails.builder()
+        return builder()
                 .clientName(clientName)
                 .providerName(providerName)
                 .flagsChanged(providerEventDetails.getFlagsChanged())
diff --git a/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java b/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java
index db28555ac..d159c73de 100644
--- a/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java
+++ b/src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java
@@ -18,6 +18,7 @@
  * Configuration here will be shared across all {@link Client}s.
  */
 @Slf4j
+@SuppressWarnings("PMD.UnusedLocalVariable")
 public class OpenFeatureAPI implements EventBus<OpenFeatureAPI> {
     // package-private multi-read/single-write lock
     static AutoCloseableReentrantReadWriteLock lock = new AutoCloseableReentrantReadWriteLock();
diff --git a/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java b/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java
index ce763a34b..b03ef6aa6 100644
--- a/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java
+++ b/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java
@@ -19,7 +19,8 @@
  * {@inheritDoc}
  */
 @Slf4j
-@SuppressWarnings({ "PMD.DataflowAnomalyAnalysis", "PMD.BeanMembersShouldSerialize", "unchecked", "rawtypes" })
+@SuppressWarnings({ "PMD.DataflowAnomalyAnalysis", "PMD.BeanMembersShouldSerialize",
+                    "PMD.UnusedLocalVariable", "unchecked", "rawtypes" })
 public class OpenFeatureClient implements Client {
 
     private final OpenFeatureAPI openfeatureApi;