Skip to content

Commit 699bf53

Browse files
committed
fixup! Update test harness (add assertions) #1467
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
1 parent 74e983b commit 699bf53

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

tests/features/data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,6 @@ def context_func(flag: InMemoryFlag, evaluation_context: EvaluationContext):
7979
"integer": 2,
8080
"float": 0.1,
8181
"boolean": True,
82-
}
82+
},
8383
),
8484
}

tests/features/steps/flag_steps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33

44
@given('a {flag_type}-flag with key "{flag_key}" and a default value "{default_value}"')
5-
def step_impl(context, flag_type: str, flag_key, default_value):
5+
def step_impl_flag(context, flag_type: str, flag_key, default_value):
66
context.flag = (flag_type, flag_key, default_value)
77

88

99
@when("the flag was evaluated with details")
10-
def step_impl(context):
10+
def step_impl_evaluation(context):
1111
client = context.client
1212
flag_type, key, default_value = context.flag
1313
if flag_type.lower() == "string":

tests/features/steps/metadata_steps.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,36 +6,38 @@
66

77

88
@given("a stable provider")
9-
def step_impl(context):
9+
def step_impl_stable_provider(context):
1010
set_provider(InMemoryProvider(IN_MEMORY_FLAGS))
1111
context.client = get_client()
1212

1313

1414
@then('the resolved metadata value "{key}" should be "{value}"')
15-
def step_impl(context, key, value):
15+
def step_impl_check_metadata(context, key, value):
1616
assert context.evaluation.flag_metadata[key] == value
1717

1818

1919
@then("the resolved metadata is empty")
20-
def step_impl(context):
20+
def step_impl_empty_metadata(context):
2121
assert not context.evaluation.flag_metadata
2222

2323

2424
@then("the resolved metadata should contain")
25-
def step_impl(context):
25+
def step_impl_metadata_contains(context):
2626
for row in context.table:
2727
key, metadata_type, value = row
2828

29-
assert context.evaluation.flag_metadata[key] == convert_value_from_metadata_type(value, metadata_type)
29+
assert context.evaluation.flag_metadata[
30+
key
31+
] == convert_value_from_metadata_type(value, metadata_type)
3032

3133

3234
def convert_value_from_metadata_type(value, metadata_type):
3335
if value == "None":
3436
return None
35-
if metadata_type.lower() == 'boolean':
37+
if metadata_type.lower() == "boolean":
3638
return bool(value)
37-
elif metadata_type.lower() == 'integer':
39+
elif metadata_type.lower() == "integer":
3840
return int(value)
39-
elif metadata_type.lower() == 'float':
41+
elif metadata_type.lower() == "float":
4042
return float(value)
4143
return value

0 commit comments

Comments
 (0)