From 86620c27ed19b9fc2e2746b443cd8ee8e6bc7fdf Mon Sep 17 00:00:00 2001 From: Lukas Reining Date: Tue, 19 Nov 2024 10:29:49 +0100 Subject: [PATCH] feat: pr feedback Signed-off-by: Lukas Reining --- openfeature/api.py | 4 ++-- openfeature/transaction_context/__init__.py | 1 - .../no_op_transaction_context_propagator.py | 6 ++---- .../transaction_context/transaction_context_propagator.py | 3 --- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/openfeature/api.py b/openfeature/api.py index 847f7daa..c7d29c48 100644 --- a/openfeature/api.py +++ b/openfeature/api.py @@ -12,9 +12,9 @@ from openfeature.provider import FeatureProvider from openfeature.provider._registry import provider_registry from openfeature.provider.metadata import Metadata -from openfeature.transaction_context import ( +from openfeature.transaction_context import TransactionContextPropagator +from openfeature.transaction_context.no_op_transaction_context_propagator import ( NoOpTransactionContextPropagator, - TransactionContextPropagator, ) __all__ = [ diff --git a/openfeature/transaction_context/__init__.py b/openfeature/transaction_context/__init__.py index e9659cb2..af5aca42 100644 --- a/openfeature/transaction_context/__init__.py +++ b/openfeature/transaction_context/__init__.py @@ -10,6 +10,5 @@ __all__ = [ "TransactionContextPropagator", - "NoOpTransactionContextPropagator", "ContextVarsTransactionContextPropagator", ] diff --git a/openfeature/transaction_context/no_op_transaction_context_propagator.py b/openfeature/transaction_context/no_op_transaction_context_propagator.py index 01069ffe..22a5a3f1 100644 --- a/openfeature/transaction_context/no_op_transaction_context_propagator.py +++ b/openfeature/transaction_context/no_op_transaction_context_propagator.py @@ -8,7 +8,5 @@ class NoOpTransactionContextPropagator(TransactionContextPropagator): def get_transaction_context(self) -> EvaluationContext: return EvaluationContext() - def set_transaction_context( - self, transaction_context: EvaluationContext - ) -> None: - pass + def set_transaction_context(self, transaction_context: EvaluationContext) -> None: + pass diff --git a/openfeature/transaction_context/transaction_context_propagator.py b/openfeature/transaction_context/transaction_context_propagator.py index 07c87a77..9a54367b 100644 --- a/openfeature/transaction_context/transaction_context_propagator.py +++ b/openfeature/transaction_context/transaction_context_propagator.py @@ -1,10 +1,7 @@ import typing -from typing import TypeVar from openfeature.evaluation_context import EvaluationContext -T = TypeVar("T", bound="TransactionContextPropagator") - class TransactionContextPropagator(typing.Protocol): def get_transaction_context(self) -> EvaluationContext: ...