-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Javascript coding style problems" from moodle.org/plugins prechecker to moodle-plugin-ci #95
Comments
Hi @polothy , may I ping you if you have an idea about this gap? Thanks, |
Hrm... I don't know what the |
Thank you @polothy . I have raised this question in Moodle Dev Chat to see if anyone from Moodle HQ can shed a light on this architecture. |
It's an eslint warning which matches https://eslint.org/docs/rules/spaced-comment The line in question is:
You can fix this in several ways:
It's a valid issue, not a bug in the checker. You can see the same thing by running eslint manually:
|
Thanks, @andrewnicols , for your quick feedback about the underlying coding style problem. I will use your improvement proposal soon to improve the code. However, my question was about the fact that this coding style problem is reported by the moodle.org/plugins prechecker but not by Travis CI which is running local_codechecker. @polothy was wondering if these eslint checks are only performed by moodle-local_ci in the Moodle plugins repository. Do you also have any insights about that for me? Thanks, |
Hey @andrewnicols , may I ping you again about the pending question from my comment above?
Thanks, |
hi! I added an option to run grunt with arguments to show/fail on lint warnings, see #111 |
Hi,
I have noticed that the moodle.org/plugins prechecker runs some check on the Javascript Coding style which are currently not reported by moodle-plugin-ci.
For an example, please see
https://moodle.org/plugins/pluginversion.php?id=19343&smurf=html#js
where this error is reported:
At the same time, the corresponding Job in Travis CI does not report any problems with JavaScript:
https://travis-ci.org/moodleuulm/moodle-atto_styles/jobs/518201841
Do you have an idea if these JavaScript checks can also be added to moodle-plugin-ci?
Cheers,
Alex
The text was updated successfully, but these errors were encountered: