Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/779 state serialization #780

Open
wants to merge 15 commits into
base: dev/state-persistence
Choose a base branch
from
Open

Feature/779 state serialization #780

wants to merge 15 commits into from

Conversation

davidhjp01
Copy link
Contributor

@davidhjp01 davidhjp01 commented Dec 10, 2024 •
edited
Loading

closes #779

  • Uses libcbor for (de)serialization.
  • Overrides << and >> to (de)seserialize cosim::serialization::node object to std::o/istream
  • Added state_serilization_test.cpp which is based on save_state_test.cpp for testing.
  • Extended save_state_test.cpp for testing export and import of states to/from files
  • Added print_ptree for replacing the previous << operator for pretty-printing cosim::serialization::node.

TODOs

  • Add missing comments to the new APIs.

@davidhjp01 davidhjp01 linked an issue Dec 10, 2024 that may be closed by this pull request
Implement CBOR based de-/serializer for state import/export #779
Open
3 tasks
@davidhjp01 davidhjp01 changed the base branch from master to dev/state-persistence December 10, 2024 04:18
@davidhjp01 davidhjp01 changed the base branch from dev/state-persistence to master December 10, 2024 04:20
@davidhjp01 davidhjp01 marked this pull request as draft December 10, 2024 04:51
@davidhjp01 davidhjp01 changed the base branch from master to dev/state-persistence December 10, 2024 08:16
@davidhjp01 davidhjp01 marked this pull request as ready for review January 15, 2025 08:21
@davidhjp01
Copy link
Contributor Author

@kyllingstad, @restenb the PR is ready for your reviews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyllingstad kyllingstad Awaiting requested review from kyllingstad

@restenb restenb Awaiting requested review from restenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CBOR based de-/serializer for state import/export
2 participants
@davidhjp01 @kyllingstad