From 4df4f3b0a279aa2339f27a836639412a27698722 Mon Sep 17 00:00:00 2001 From: Pablo Baeyens Date: Fri, 24 Jan 2025 14:10:58 +0100 Subject: [PATCH] Add explicit TODO --- internal/otelarrow/netstats/netstats_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/internal/otelarrow/netstats/netstats_test.go b/internal/otelarrow/netstats/netstats_test.go index 937bf08dbbac..e06a02c63eba 100644 --- a/internal/otelarrow/netstats/netstats_test.go +++ b/internal/otelarrow/netstats/netstats_test.go @@ -30,6 +30,8 @@ func dropView(instrument metric.Instrument) metric.View { ) } +// TODO: This will be exposed by each component. Remove this function and use +// the publicly exposed view once this is possible to do. func viewsFromLevel(level configtelemetry.Level) []metric.View { var views []metric.View @@ -57,10 +59,6 @@ func viewsFromLevel(level configtelemetry.Level) []metric.View { ) } - // contrib's internal/otelarrow/netstats metrics - // See - // - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a25f05/internal/otelarrow/netstats/netstats.go#L130 - // - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a25f05/internal/otelarrow/netstats/netstats.go#L165 if level < configtelemetry.LevelDetailed { scope := instrumentation.Scope{Name: scopeName} // Compressed size metrics.