From f7f5dbd150071ff57562c360d536e356d933094a Mon Sep 17 00:00:00 2001 From: Janik K <10290002+led0nk@users.noreply.github.com> Date: Wed, 13 Mar 2024 23:32:01 +0100 Subject: [PATCH] [chore] lint fix in cmd/checkapi (#31723) **Description:** linting error with: ``` INFO [runner] linters took 1.336744316s with stages: goanalysis_metalinter: 1.334941582s opentelemetry-collector-contrib/cmd/checkapi/main.go:50:66: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive) err = filepath.Walk(folder, func(path string, info fs.FileInfo, err error) error { ^ ``` and: ``` INFO [runner] linters took 1.806204856s with stages: goanalysis_metalinter: 1.80522593s opentelemetry-collector-contrib/cmd/checkapi/main.go:53:18: shadow: declaration of "err" shadows declaration at line 44 (govet) relativeBase, err := filepath.Rel(folder, base) ^ ``` **Link to tracking Issue:** - #31240 **Testing:** **Documentation:** --- cmd/checkapi/main.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/checkapi/main.go b/cmd/checkapi/main.go index 50d2bff18a71..5e99e6237c36 100644 --- a/cmd/checkapi/main.go +++ b/cmd/checkapi/main.go @@ -47,10 +47,11 @@ func run(folder string, allowlistFilePath string) error { } allowlist := strings.Split(string(allowlistData), "\n") var errs []error - err = filepath.Walk(folder, func(path string, info fs.FileInfo, err error) error { + err = filepath.Walk(folder, func(path string, info fs.FileInfo, _ error) error { if info.Name() == "go.mod" { base := filepath.Dir(path) - relativeBase, err := filepath.Rel(folder, base) + var relativeBase string + relativeBase, err = filepath.Rel(folder, base) if err != nil { return err } @@ -67,7 +68,7 @@ func run(folder string, allowlistFilePath string) error { return nil } } - if err := walkFolder(base, componentType); err != nil { + if err = walkFolder(base, componentType); err != nil { errs = append(errs, err) } }