[pkg/ottl] Add Day converter
#33121
Merged
[pkg/ottl] Add Day converter
#33121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkingpoint
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
evan-bradley
approved these changes
May 20, 2024
sinkingpoint
force-pushed
the
sinkingpoint/add-day-converter
branch
from
0dff0be to
ae60a8a
Compare
|
Thanks for the review @evan-bradley ! I've updated it with your changes. Those build failures seem unrelated? |
This adds a `Day` converter that extracts the int day component from a `time.Time` Signed-off-by: sinkingpoint <colin@quirl.co.nz>
Signed-off-by: sinkingpoint <colin@quirl.co.nz>
sinkingpoint
force-pushed
the
sinkingpoint/add-day-converter
branch
from
ae60a8a to
3823c42
Compare
|
cc @TylerHelmuth if you want to look, this is the same as the |
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
TylerHelmuth
approved these changes
May 22, 2024
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds in a
Dayconverter that takes atime.Timeand returns the int day component. Analogous to what we already have withHourLink to tracking Issue: #33106
Testing: Added two unit tests based on the existing
HouronesDocumentation: Added the new converter to the ottlfuncs README.md