[processor/resourcedetection] Add support for detecting GCE VMs in Managed Instance Groups #36142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
|
I'll be OOO for a few weeks, and might not be able to get to this right away |
dashpole
reviewed
Nov 14, 2024
processor/resourcedetectionprocessor/internal/gcp/documentation.md
Outdated
Show resolved
Hide resolved
dashpole
approved these changes
Nov 20, 2024
|
Looks like this needs a changelog |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Not stale, just blocked on the final names for the attributes. |
quentinmit
force-pushed
the
gcp-gce-mig
branch
from
6fc73b1 to
028e0fc
Compare
Alright, I think the naming is unblocked (we switched to underscores after discussing this at the Entity SIG). PTAL again and thanks! |
dashpole
reviewed
Dec 19, 2024
dashpole
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds resource detection for the GCE "instance group manager" that created an instance, allowing like VMs to be grouped using a resource attribute.
I also have corresponding branches prepared for opentelemetry-go and semantic-conventions
Testing
This PR includes unit tests to validate that the correct resource attributes are added, and I manually tested a collector built with this change on a MIG VM and it generates the expected resource attributes.
Documentation
Documented with the other resource attributes in the existing documentation.