-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[chore] Fix the job updating otelcol core dependency #37149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12713829455/job/35445661001 by adding pissing `path`. Other additions are improvements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37149 +/- ##
==========================================
- Coverage 79.60% 79.58% -0.02%
==========================================
Files 2252 2252
Lines 211920 211920
==========================================
- Hits 168704 168667 -37
- Misses 37549 37581 +32
- Partials 5667 5672 +5 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Jan 10, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…37149) Fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12713829455/job/35445661001 by adding missing `path` field. Other additions are improvements
dmitryax
added a commit
that referenced
this pull request
Jan 13, 2025
I took them from another OTel project and added them in #37149, but the values are invalid. A multiline YAML flag is missing. I'm removing them for now since I don't think they are necessary.
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…etry#37151) I took them from another OTel project and added them in open-telemetry#37149, but the values are invalid. A multiline YAML flag is missing. I'm removing them for now since I don't think they are necessary.
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…37149) Fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12713829455/job/35445661001 by adding missing `path` field. Other additions are improvements
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…etry#37151) I took them from another OTel project and added them in open-telemetry#37149, but the values are invalid. A multiline YAML flag is missing. I'm removing them for now since I don't think they are necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12713829455/job/35445661001 by adding missing
path
field. Other additions are improvements