Um ... MetricPoint Um.. wtf? #5915
Replies: 1 comment
-
|
Not clear what is the actual ask/issue. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Created a customer exporter to write to a CSV file and happened to look at the source code for the MetricPoint class.
ThrowNotSupportedMetricTypeException is used to throw a NotSupportedException
Um using an exception like this is an indication of badly designed code, hopefully this is already know and its going to be fixed in a future updates. Its also bad for performance if these exceptions get triggered at runtime.
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs#L1096
I considered posting to The daily WTF as yes its that bad so hopefully this is planed to be fixed.
Beta Was this translation helpful? Give feedback.
All reactions