Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link tracing information displayed by Zipkin is incorrect #2794

Open
benxionghu opened this issue Jan 18, 2022 · 4 comments
Open

The link tracing information displayed by Zipkin is incorrect #2794

benxionghu opened this issue Jan 18, 2022 · 4 comments
Labels
question Further information is requested

Comments

@benxionghu
Copy link

benxionghu commented Jan 18, 2022

Question

Item link error in Zipkin

I have a demo project, called link is gateway - > payapi - > orderApi - > ProductApi, but he was payapi orderApi/ProductApi display link is wrong

Describe your environment.
NetCore 6.0
OpenTelemetry 1.2.0-rc1
OpenTelemetry.Exporter.Zipkin 1.2.0-rc1
OpenTelemetry.Extensions.Hosting 1.0.0-rc8

The way I inject it:

 public static IServiceCollection AddZipKin(this IServiceCollection services, string serverName, string zipUrl)
        {
            var serviceVersion = "1.0.0";
            return services.AddOpenTelemetryTracing(tracing =>
            {
                tracing.AddConsoleExporter()
                    .SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(serverName, serviceVersion))
                    //.AddHttpClientInstrumentation()
                    .AddAspNetCoreInstrumentation()
                    //.AddCapInstrumentation()
                    .AddZipkinExporter(options =>
                    {
                        options.Endpoint = new System.Uri(zipUrl);
                        options.HttpClientFactory = () =>
                        {
                            HttpClient client = new HttpClient();
                            client.DefaultRequestHeaders.Add("X-MyCustomHeader", "value");
                            return client;
                        };
                    });
            });
        }

Describe any aspect of your environment relevant to the question.
Error request link display diagram:
image

image

What are you trying to achieve?

I think the correct display would be gateway--> PayAPI -->orderApi-->ProductApi,

I'm not sure if I'm missing something or is this a problem in the latest version

What did you expect to see?

Additional Context

Add any other context about the problem here. If you followed an existing
documentation, please share the link to it.

@benxionghu benxionghu added the question Further information is requested label Jan 18, 2022
@benxionghu benxionghu changed the title Item link error in Zipkin The link tracing information displayed by Zipkin is incorrect Jan 18, 2022
@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 26, 2022
@mic-max
Copy link
Contributor

mic-max commented Jan 26, 2022

So, you're saying it should appear like this, correct?

Gateway
├─ PayAPI
     ├─ OrderAPI
           ├─ ProductAPI

@cijothomas cijothomas removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 27, 2022
@benxionghu
Copy link
Author

所以,你是说它应该看起来像这样,对吗?

Gateway
├─ PayAPI
     ├─ OrderAPI
           ├─ ProductAPI

Yeah, that's how it should be presented

@benxionghu
Copy link
Author

所以,你是说它应该看起来像这样,对吗?

Gateway
├─ PayAPI
     ├─ OrderAPI
           ├─ ProductAPI

Is there a best solution to this?

@stevejgordon
Copy link
Contributor

@benxionghu, is this still an issue for you on the latest releases? If so, could you please provide us with a Minimal, Reproducible Example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants