Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] Prepare release core-1.9.0 #5690

Closed
wants to merge 1 commit into from
Closed

[release] Prepare release core-1.9.0 #5690

wants to merge 1 commit into from

Conversation

opentelemetrybot
Copy link
Collaborator

Note: This PR was opened automatically by the prepare release workflow.

Changes

  • CHANGELOG files updated for projects being released.
  • Public API files updated for projects being released (only performed for stable releases).

@opentelemetrybot opentelemetrybot requested a review from a team June 12, 2024 19:33
@opentelemetrybot opentelemetrybot added the release Related to the release process label Jun 12, 2024
@CodeBlanch CodeBlanch marked this pull request as draft June 12, 2024 19:34
@github-actions github-actions bot added pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry.Extensions.Propagators Issues related to OpenTelemetry.Extensions.Propagators NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jun 12, 2024
@CodeBlanch
Copy link
Member

@alanwest @vishweshbankwar @Kielek @utpilla @cijothomas

Release isn't going to happen for another couple days but please review public API on this diff and raise any concerns early!

Kielek
Kielek approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do not see anything problematic if we speaking about Automatic Instrumentation.

Please remember to update release date in changelogs (can it be additional argument for creating PR?) when you decide to merge.

reyang
reyang reviewed Jun 14, 2024
View reviewed changes
src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md
@@ -2,6 +2,10 @@

## Unreleased

## 1.9.0

Released 2024-Jun-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Released 2024-Jun-12
Released 2024-Jun-14

reyang
reyang approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the release date will be updated to Jun-14-2024.

@CodeBlanch CodeBlanch closed this Jun 14, 2024
@CodeBlanch CodeBlanch deleted the release/prepare-core-1.9.0-release branch June 14, 2024 19:30
@CodeBlanch
Copy link
Member

Opened a new one to get the correct dates: #5694

Please remember to update release date in changelogs (can it be additional argument for creating PR?) when you decide to merge.

@Kielek I like the idea to make the date configurable. I'll jot it down and come to it at some point. Also thinking it would be good to mention who requested the release/kicked off the workflow.

@CodeBlanch CodeBlanch mentioned this pull request Jun 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@reyang reyang reyang approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@Kielek Kielek Kielek approved these changes

@cijothomas cijothomas cijothomas approved these changes

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry.Extensions.Propagators Issues related to OpenTelemetry.Extensions.Propagators NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package release Related to the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@opentelemetrybot @CodeBlanch @alanwest @cijothomas @Kielek @rajkumar-rangaraj @reyang @vishweshbankwar