Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Buffer Size Handling with Retry Logic and OTLP Signal Path #5988

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

rajkumar-rangaraj
Copy link
Contributor

Follow up #5977
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Added exception handling to IncreaseBufferSize and moved it to ProtobufSerializer.
  • Added retry logic for the batch in case of buffer overrun.
  • Added the missing signal path required to send data to the OTLP endpoint for logs and metrics.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner November 18, 2024 21:27
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 21.56863% with 40 lines in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (e3665c9) to head (3fc85c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 0.00% 16 Missing ⚠️
...ol/Implementation/Serializer/ProtobufSerializer.cs 0.00% 12 Missing ⚠️
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 50.00% 7 Missing ⚠️
...ation/ExportClient/ProtobufOtlpHttpExportClient.cs 0.00% 1 Missing ⚠️
...tlpExporterPersistentStorageTransmissionHandler.cs 0.00% 1 Missing ⚠️
...r.OpenTelemetryProtocol/ProtobufOtlpLogExporter.cs 0.00% 1 Missing ⚠️
...penTelemetryProtocol/ProtobufOtlpMetricExporter.cs 0.00% 1 Missing ⚠️
...OpenTelemetryProtocol/ProtobufOtlpTraceExporter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5988      +/-   ##
==========================================
- Coverage   84.14%   83.98%   -0.17%     
==========================================
  Files         275      275              
  Lines       12560    12582      +22     
==========================================
- Hits        10569    10567       -2     
- Misses       1991     2015      +24     
Flag Coverage Δ
unittests-Project-Experimental 83.98% <21.56%> (-0.13%) ⬇️
unittests-Project-Stable 83.92% <21.56%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <100.00%> (+1.66%) ⬆️
...ation/ExportClient/ProtobufOtlpHttpExportClient.cs 0.00% <0.00%> (ø)
...tlpExporterPersistentStorageTransmissionHandler.cs 0.00% <0.00%> (ø)
...r.OpenTelemetryProtocol/ProtobufOtlpLogExporter.cs 0.00% <0.00%> (ø)
...penTelemetryProtocol/ProtobufOtlpMetricExporter.cs 0.00% <0.00%> (ø)
...OpenTelemetryProtocol/ProtobufOtlpTraceExporter.cs 0.00% <0.00%> (ø)
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 87.35% <50.00%> (-2.29%) ⬇️
...ol/Implementation/Serializer/ProtobufSerializer.cs 87.69% <0.00%> (-8.92%) ⬇️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 75.69% <0.00%> (-5.86%) ⬇️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit f9a0b4c into open-telemetry:main Nov 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants