squash: active record

Author: arielvalentin

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/persistence.rb

@@ -29,91 +29,91 @@ def destroy!
             end
           end
 
-          def becomes(klass)
+          def becomes(...)
             tracer.in_span("#{self.class}#becomes") do
               super
             end
           end
 
-          def becomes!(klass)
+          def becomes!(...)
             tracer.in_span("#{self.class}#becomes!") do
               super
             end
           end
 
-          def update_attribute(name, value)
+          def update_attribute(...)
             tracer.in_span("#{self.class}#update_attribute") do
               super
             end
           end
 
-          def update(attributes)
+          def update(...)
             tracer.in_span("#{self.class}#update") do
               super
             end
           end
 
-          def update!(attributes)
+          def update!(...)
             tracer.in_span("#{self.class}#update!") do
               super
             end
           end
 
-          def update_column(name, value)
+          def update_column(...)
             tracer.in_span("#{self.class}#update_column") do
               super
             end
           end
 
-          def update_columns(attributes)
+          def update_columns(...)
             tracer.in_span("#{self.class}#update_columns") do
               super
             end
           end
 
-          def increment(attribute, by = 1)
+          def increment(...)
             tracer.in_span("#{self.class}#increment") do
               super
             end
           end
 
-          def increment!(attribute, by = 1, touch: nil)
+          def increment!(...)
             tracer.in_span("#{self.class}#increment!") do
               super
             end
           end
 
-          def decrement(attribute, by = 1)
+          def decrement(...)
             tracer.in_span("#{self.class}#decrement") do
               super
             end
           end
 
-          def decrement!(attribute, by = 1, touch: nil)
+          def decrement!(...)
             tracer.in_span("#{self.class}#decrement!") do
               super
             end
           end
 
-          def toggle(attribute)
+          def toggle(...)
             tracer.in_span("#{self.class}#toggle") do
               super
             end
           end
 
-          def toggle!(attribute)
+          def toggle!(...)
             tracer.in_span("#{self.class}#toggle!") do
               super
             end
           end
 
-          def reload(options = nil)
+          def reload(...)
             tracer.in_span("#{self.class}#reload") do
               super
             end
           end
 
-          def touch(*names, time: nil)
+          def touch(...)
             tracer.in_span("#{self.class}#touch") do
               super
             end

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/persistence_class_methods.rb

@@ -18,31 +18,31 @@ class << base
 
           # Contains ActiveRecord::Persistence::ClassMethods to be patched
           module ClassMethods
-            def create(attributes = nil, &block)
+            def create(...)
               tracer.in_span("#{self}.create") do
                 super
               end
             end
 
-            def create!(attributes = nil, &block)
+            def create!(...)
               tracer.in_span("#{self}.create!") do
                 super
               end
             end
 
-            def update(id = :all, attributes) # rubocop:disable Style/OptionalArguments
+            def update(...)
               tracer.in_span("#{self}.update") do
                 super
               end
             end
 
-            def destroy(id)
+            def destroy(...)
               tracer.in_span("#{self}.destroy") do
                 super
               end
             end
 
-            def delete(id_or_array)
+            def delete(...)
               tracer.in_span("#{self}.delete") do
                 super
               end

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/persistence_insert_class_methods.rb

@@ -18,37 +18,37 @@ class << base
 
           # Contains ActiveRecord::Persistence::ClassMethods to be patched
           module ClassMethods
-            ruby2_keywords def insert(*args)
+            def insert(...)
               tracer.in_span("#{self}.insert") do
                 super
               end
             end
 
-            ruby2_keywords def insert_all(*args)
+            def insert_all(...)
               tracer.in_span("#{self}.insert_all") do
                 super
               end
             end
 
-            ruby2_keywords def insert!(*args)
+            def insert!(...)
               tracer.in_span("#{self}.insert!") do
                 super
               end
             end
 
-            ruby2_keywords def insert_all!(*args)
+            def insert_all!(...)
               tracer.in_span("#{self}.insert_all!") do
                 super
               end
             end
 
-            ruby2_keywords def upsert(*args)
+            def upsert(...)
               tracer.in_span("#{self}.upsert") do
                 super
               end
             end
 
-            ruby2_keywords def upsert_all(*args)
+            def upsert_all(...)
               tracer.in_span("#{self}.upsert_all") do
                 super
               end

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/relation_persistence.rb

@@ -10,13 +10,13 @@ module ActiveRecord
       module Patches
         # Module to prepend to ActiveRecord::Relation for instrumentation
         module RelationPersistence
-          def update_all(*)
+          def update_all(...)
             tracer.in_span("#{model.name}.update_all") do
               super
             end
           end
 
-          def delete_all(*)
+          def delete_all(...)
             tracer.in_span("#{model.name}.delete_all") do
               super
             end

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/transactions_class_methods.rb

@@ -18,7 +18,7 @@ class << base
 
           # Contains ActiveRecord::Transactions::ClassMethods to be patched
           module ClassMethods
-            def transaction(**options, &block)
+            def transaction(...)
               tracer.in_span('ActiveRecord.transaction', attributes: { 'code.namespace' => name }) do
                 super
               end

instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/validations.rb

@@ -14,13 +14,13 @@ module Patches
         # https://github.com/rails/rails/blob/v5.2.4.5/activerecord/lib/active_record/validations.rb#L42-L53
         # Contains the ActiveRecord::Validations methods to be patched
         module Validations
-          def save(**options)
+          def save(...)
             tracer.in_span("#{self.class}#save") do
               super
             end
           end
 
-          def save!(**options)
+          def save!(...)
             tracer.in_span("#{self.class}#save!") do
               super
             end